OIDC Timeout and Web UI #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russjones
force-pushed
the
rjones/oidc-ux
branch
2 times, most recently
from
a1cbe64
to
797c88c
Compare
russjones
force-pushed
the
rjones/oidc-ux
branch
from
797c88c
to
95192e3
Compare
klizhentas
approved these changes
Apr 7, 2017
alex-kovoy
reviewed
Apr 7, 2017
|
|
||
| // redirect to an error page | ||
| pathToError := url.URL{ | ||
| Path: "/web/msg/error/login_failed", |
There was a problem hiding this comment.
lets start using constants for UI route strings
hatched
pushed a commit
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
As covered in #910, when a OIDC request takes longer than 60 seconds, something like the following is presented in the web browser:
{"message":"[web connectors oidc requests]: c94b359a1b1c11e793b7ac87a30d221b not found"}This PR changes this behavior in two ways:
defaults.Implementation
/web/msg/error/login_failedupon errors during login.Related Issues
Fixes #910