Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add drm gen for CTIME (daily) data #18

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

felixthebeard
Copy link
Contributor

No description provided.

@grburgess
Copy link
Owner

This did not trigger an action. Is it up to date with the master?

@grburgess grburgess self-assigned this Feb 22, 2021
@felixthebeard felixthebeard changed the base branch from master to testing May 13, 2021 14:18
@felixthebeard felixthebeard changed the base branch from testing to master May 13, 2021 14:18
@codecov-commenter
Copy link

Codecov Report

Merging #18 (053e2d1) into master (65f9fe8) will decrease coverage by 20.62%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #18       +/-   ##
===========================================
- Coverage   54.58%   33.96%   -20.63%     
===========================================
  Files          24       25        +1     
  Lines        1570     1587       +17     
===========================================
- Hits          857      539      -318     
- Misses        713     1048      +335     
Impacted Files Coverage Δ
gbm_drm_gen/drmgen_ctime.py 24.44% <24.44%> (ø)
gbm_drm_gen/__init__.py 88.23% <66.66%> (+0.73%) ⬆️
gbm_drm_gen/input_edges.py 84.00% <83.33%> (ø)
gbm_drm_gen/matrix_functions.py 4.64% <0.00%> (-92.11%) ⬇️
gbm_drm_gen/drmgen.py 50.00% <0.00%> (-36.96%) ⬇️
gbm_drm_gen/test/test_drm_gen.py 91.30% <0.00%> (-8.70%) ⬇️
gbm_drm_gen/io/balrog_healpix_map.py 37.93% <0.00%> (-7.53%) ⬇️
gbm_drm_gen/utils/contour_finder.py 38.46% <0.00%> (-6.37%) ⬇️
gbm_drm_gen/io/palantir.py 16.66% <0.00%> (-1.52%) ⬇️
gbm_drm_gen/_version.py 41.15% <0.00%> (-0.43%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65f9fe8...053e2d1. Read the comment docs.

@grburgess
Copy link
Owner

@fkunzweiler all is good, but can you add some tests for the CTIME to keep the coverage up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants