When updating a version ignore the current version in case of erros #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
…rors During a version update the project's current version is parsed. This may result in VersionErrors if for example the versioning scheme is changed and the new versioning scheme doesn't recognize the current version format (PEP440 based 22.4.1.dev1 can't be parsed as semver). The current version is just parsed during the update to check if it is a real update or if the same version is set. Therefore ignore the VersionErrors during the version update and just set the new version.
bjoernricks
force-pushed
the
ignore-current-version-error-during-version-update
branch
from
47d16f8
to
bfa662d
Compare
Codecov Report
@@ Coverage Diff @@
## main #804 +/- ##
==========================================
+ Coverage 89.67% 89.74% +0.06%
==========================================
Files 82 82
Lines 5406 5421 +15
Branches 762 762
==========================================
+ Hits 4848 4865 +17
+ Misses 390 389 -1
+ Partials 168 167 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
y0urself
approved these changes
Jul 3, 2023
bjoernricks
deleted the
ignore-current-version-error-during-version-update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When updating a version ignore the current version in case of erros
Why
During a version update the project's current version is parsed. This may result in VersionErrors if for example the versioning scheme is changed and the new versioning scheme doesn't recognize the current version format (PEP440 based 22.4.1.dev1 can't be parsed as semver).
The current version is just parsed during the update to check if it is a real update or if the same version is set. Therefore ignore the VersionErrors during the version update and just set the new version.