Download release files URL #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow to define the URL being displayed in the terminal.
Conventional Commits Report
🚀 Conventional commits found. |
Codecov Report
@@ Coverage Diff @@
## main #814 +/- ##
=======================================
Coverage 89.45% 89.45%
=======================================
Files 82 82
Lines 5443 5444 +1
Branches 765 765
=======================================
+ Hits 4869 4870 +1
Misses 406 406
Partials 168 168
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bjoernricks
force-pushed
the
download-release-files-url
branch
from
270a1bd
to
1c6bf70
Compare
Before the URL of the response was used. GitHub uses a lot of redirects. Therefore the response URL contained the last redirected URL. Displaying the originally requested URL seems to be much better at least for release files.
bjoernricks
force-pushed
the
download-release-files-url
branch
from
1c6bf70
to
2504aa5
Compare
y0urself
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Display the requested URL when downloading release files.
Why
GitHub uses a lot of redirects to get the final URL where the corresponding release file will be downloaded. Before this final URL has been shown in the terminal. Because this URL may be very long and may not contain the original requested file name it was difficult to understand what's actually being downloaded. Instead display the requested URL in the terminal when downloading release files.
Checklist