Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Allow to enforce uploading releases as GitHub pre-releases #894

Merged
merged 4 commits into from
Oct 5, 2023

Conversation

bjoernricks
Copy link
Contributor

What

Allow to enforce uploading releases as GitHub pre-releases. Add a new flag --github-pre-release to pontos-release create.

Why

When creating a release it is now possible to enforce uploading the release with a pre-release status to GitHub.

References

DEVOPS-826

Checklist

  • Tests

When creating a release it is now possible to enforce uploading the
release with a pre-release status to GitHub.
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Conventional Commits Report

Type Number
Added 2
Changed 1

🚀 Conventional commits found.

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #894 (ae3adf2) into main (9222594) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #894   +/-   ##
=======================================
  Coverage   89.84%   89.84%           
=======================================
  Files          88       88           
  Lines        5907     5908    +1     
  Branches      837      837           
=======================================
+ Hits         5307     5308    +1     
  Misses        421      421           
  Partials      179      179           
Files Coverage Δ
pontos/git/git.py 98.11% <100.00%> (ø)
pontos/release/create.py 97.29% <100.00%> (ø)
pontos/release/parser.py 97.56% <100.00%> (+0.03%) ⬆️
pontos/version/commands/_command.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bjoernricks bjoernricks marked this pull request as ready for review October 5, 2023 09:26
@bjoernricks bjoernricks requested a review from a team as a code owner October 5, 2023 09:26
@bjoernricks bjoernricks enabled auto-merge (rebase) October 5, 2023 10:58
The CLI subcommand is intended to create a release and therefore got
renamed from `release` to `create`. Adjust the tests to reflect this
change.
@bjoernricks bjoernricks marked this pull request as draft October 5, 2023 12:13
auto-merge was automatically disabled October 5, 2023 12:13

Pull request was converted to draft

…eate`

Ensure the correct behavior of parsing the new flag.
@bjoernricks bjoernricks marked this pull request as ready for review October 5, 2023 12:17
@greenbonebot greenbonebot enabled auto-merge (squash) October 5, 2023 12:17
@greenbonebot greenbonebot merged commit 710fb09 into main Oct 5, 2023
18 checks passed
@greenbonebot greenbonebot deleted the github-pre-release branch October 5, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants