Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new pub #45

Closed
wants to merge 4 commits into from
Closed

Add new pub #45

wants to merge 4 commits into from

Conversation

ajlee21
Copy link
Contributor

@ajlee21 ajlee21 commented Apr 1, 2022

No description provided.

@netlify
Copy link

netlify bot commented Apr 1, 2022

Deploy Preview for greenelab-website ready!

Name Link
🔨 Latest commit 518a59f
🔍 Latest deploy log https://app.netlify.com/sites/greenelab-website/deploys/62476a365b386c00088ab711
😎 Deploy Preview https://deploy-preview-45--greenelab-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ajlee21 ajlee21 changed the title Add new pub and minor updates Add new pub Apr 1, 2022
@ajlee21
Copy link
Contributor Author

ajlee21 commented Apr 1, 2022

@vincerubinetti not sure if you can help with this error check. There is an error with the auto-cite generation

  Source 1 of 139 - doi.org/10.48550/arXiv.2203.13946
    Using Manubot to generate new citation
    Manubot could not generate citation

@ajlee21
Copy link
Contributor Author

ajlee21 commented Apr 1, 2022

I'm not sure if this is related. But I also tried to update existing entries in the sources.yml file but got the following error

Run stefanzweifel/git-auto-commit-action@v4
Started: bash /home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v4/entrypoint.sh
INPUT_REPOSITORY value: .
INPUT_STATUS_OPTIONS: 
INPUT_BRANCH value: add_pub_take2
From https://github.com/greenelab/greenelab.com
 * [new branch]      add-disco2021           -> origin/add-disco2021
 * [new branch]      cgreene-preprint-to-pub -> origin/cgreene-preprint-to-pub
 * [new branch]      cgreene-two-pubs        -> origin/cgreene-two-pubs
 * [new branch]      main                    -> origin/main
fatal: invalid reference: add_pub_take2
Error: Invalid status code: 128
    at ChildProcess.<anonymous> (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v4/index.js:17:19)
    at ChildProcess.emit (events.js:314:20)
    at maybeClose (internal/child_process.js:1022:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5) {
  code: 128
}
Error: Invalid status code: 128
    at ChildProcess.<anonymous> (/home/runner/work/_actions/stefanzweifel/git-auto-commit-action/v4/index.js:17:19)
    at ChildProcess.emit (events.js:314:20)
    at maybeClose (internal/child_process.js:1022:16)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:287:5)

Which made me think that I couldn't update existing entries in the sources.yml file only add new entries. So I deleted the updates in commit a2d6b9a but when I added a new entry I got the error described above

I read this old issue where you mentioned that it might be an issue with permissions from my fork. But I did check that my forked repo has permissions.

@vincerubinetti
Copy link
Contributor

vincerubinetti commented Apr 1, 2022

doi.org/10.48550/arXiv.2203.13946

I don't believe this is a valid manubot identifier. I think you want arxiv:2203.13946. Or if you really wanted to cite it with the url, url:https://doi.org/10.48550/arXiv.2203.13946. I'm pretty sure that is why Manubot cannot generate the citation for that one. The only other possibility is that the paper is too new and metadata for it isn't available yet.

Regarding the github actions problem, that should be a separate issue. Just to verify, when you created your fork, you enabled Allow all actions and reusable workflows and Read and write permissions, before opening this PR?

If so, this seems to be an ongoing problem with stefanzweifel/git-auto-commit-action. I might have to start telling people that they just have to do PRs from a branch, not a fork. It seems like what's happening is that the target repo (in this case, greenelab/greenelab.com) is trying to run a workflow which makes a commit on a completely different repo (ajlee21/greenelab.com#add_pub_take2), and can either not find it, or doesn't have permissions to commit (write) to it.

@ajlee21
Copy link
Contributor Author

ajlee21 commented Apr 1, 2022

doi.org/10.48550/arXiv.2203.13946

I don't believe this is a valid manubot identifier. I think you want arxiv:2203.13946. Or if you really wanted to cite it with the url, url:https://doi.org/10.48550/arXiv.2203.13946. I'm pretty sure that is why Manubot cannot generate the citation for that one. The only other possibility is that the paper is too new and metadata for it isn't available yet.

Just tried to use the arxiv id and now there is the same stefanzweifel/git-auto-commit-action@v4 error so some progress!

Regarding the github actions problem, that should be a separate issue. Just to verify, when you created your fork, you enabled Allow all actions and reusable workflows and Read and write permissions, before opening this PR?

Yes

If so, this seems to be an ongoing problem with stefanzweifel/git-auto-commit-action. I might have to start telling people that they just have to do PRs from a branch, not a fork. It seems like what's happening is that the target repo (in this case, greenelab/greenelab.com) is trying to run a workflow which makes a commit on a completely different repo (ajlee21/greenelab.com#add_pub_take2), and can either not find it, or doesn't have permissions to commit (write) to it.

I can open an issue for this

@vincerubinetti
Copy link
Contributor

I'm going to open an issue on lab website template for that. For now, unfortunately, you'll probably have to redo this change yet again, except on a direct branch of greenelab.com repo. Or if you don't feel like doing that, you could build and commit the citations locally, assuming you have conda and manubot installed.

@ajlee21
Copy link
Contributor Author

ajlee21 commented Apr 1, 2022

Thanks so much @vincerubinetti for all your help! I'll make a new branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants