Add Validation::Custom variant #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greyblake
force-pushed
the
custom-error
branch
from
ed57653
to
0914419
Compare
greyblake
commented
Aug 24, 2024
greyblake
commented
Aug 24, 2024
greyblake
commented
Aug 24, 2024
test_suite/tests/integer.rs
Outdated
Comment on lines
879
to
885
| { | ||
| let err: PositivelyOddParseError = "-3".parse::<PositivelyOdd>().unwrap_err(); | ||
| assert!(matches!( | ||
| err, | ||
| PositivelyOddParseError::Validate(PositivelyOddError::Negative) | ||
| )); | ||
| } |
There was a problem hiding this comment.
This case is redundant, cause we already have -1 case above.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #161
TODO: