Correctly set page prop back to 0 when resetPageOnUpdate is enabled #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise the current page will be set to 0 but the prop will still retain its old value, causing issues with server side pagination.
|
@cpba i am noticing if you enable server side search with this change, each search is issuing two api calls instead of one. Perhaps a quick fix is to check if the props page value > 0 then only set it to 0? |
Yes, that would work. I think it'd still fire two calls if the search is started from a different page, but that'll only happen once so perhaps it isn't very important. I'll make the change. |
this way we prevent duplicated api calls.
Totally inline with that. There might be a better way to eliminate it which @afshinm can guide… |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise if there is a server side search while we're on a page other than 0, the current page is set back to 0 but the prop retains its old value. Causing issues with server side pagination as the page number that the server receives is different from the one the client is displaying.
Fixes #1311