Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mapping bytes to []byte #489

Merged
merged 6 commits into from
Jan 11, 2018
Merged

Conversation

loderunner
Copy link
Collaborator

@loderunner loderunner commented Nov 27, 2017

This PR adds support for protobuf bytes by mapping it to []byte. It uses URL-safe base64 encoding to serialize to URL query parameters.

Fixes #5

@achew22
Copy link
Collaborator

achew22 commented Nov 27, 2017

Could you also note that this fixes #5 and remove the entry from https://github.com/grpc-ecosystem/grpc-gateway/blob/master/README.md where it says "bytes fields in path parameter. #5"

@loderunner
Copy link
Collaborator Author

Done.

Could you help me out with Travis? I don't quite understand why CI is failing.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@loderunner
Copy link
Collaborator Author

Travis is failing for Go 1.8.x, any idea why?

@tmc
Copy link
Collaborator

tmc commented Dec 29, 2017

For 1.8 (we should up it to 1.9) ci fails if generating the examples causes a diff. Please regenerate examples and push again. Could you also rebase and get rid of the merge commits? Thanks!

@tmc
Copy link
Collaborator

tmc commented Jan 2, 2018

There's still a small difference:

-	"gopkg.in/go-resty/resty.v0"
+	"github.com/go-resty/resty"

@loderunner loderunner force-pushed the master branch 2 times, most recently from b0a17d8 to cb3ba62 Compare January 4, 2018 14:44
@loderunner loderunner closed this Jan 4, 2018
@loderunner loderunner reopened this Jan 4, 2018
@loderunner
Copy link
Collaborator Author

I'm getting different auto-generated files in the examples between 1.9 & master. I can't understand how to fix this. Is this a breaking change since 1.9? Or can I change this using some configuration of make?

@achew22
Copy link
Collaborator

achew22 commented Jan 10, 2018

Looking at this, it seems to me that the test we have for the go version is just wrong and it is running our clean test against go master and go 1.9.

I fixed it in #520. I'm going to get lunch and let the CI run then merge that. Sorry for all the trouble. It was an interesting bug if you wanna stare at it.

@achew22
Copy link
Collaborator

achew22 commented Jan 10, 2018

Could you rebase this onto the current HEAD? I updated the travis config so this shouldn't be a problem any more.

@loderunner
Copy link
Collaborator Author

Done. Thanks for checking that out !

@achew22
Copy link
Collaborator

achew22 commented Jan 11, 2018

No, thank you for contributing! This project is amazing for all the effort and help we've gotten from such a wide community. Thanks for joining us!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants