Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds MapGrpcService overload for ServerServiceDefinition #2535

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aka-nse
Copy link

@aka-nse aka-nse commented Sep 15, 2024

Is your feature request related to a problem? Please describe.

This PR is implement for #2236.

ServerServiceDefinition is defined in Grpc.Core.Api library, and it was a prefer way to implement gRPC server with Grpc.Core.
In current grpc-dotnet, the server should be implemented on Asp.Net web application DI container via GrpcEndpointRouteBuilderExtensions.MapGrpcService generic method.
The APIs in this proposal bridges legacy way into grpc-dotnet to enable to migrate easier.

Describe the solution you'd like

2 overloads of GrpcEndpointRouteBuilderExtensions.MapGrpcService are added:

public static class GrpcEndpointRouteBuilderExtensions
{
    public static GrpcServiceEndpointConventionBuilder MapGrpcService(
        this IEndpointRouteBuilder builder,
        ServerServiceDefinition serviceDefinition);

    public static GrpcServiceEndpointConventionBuilder MapGrpcService(
        this IEndpointRouteBuilder builder,
        Func<IServiceProvider, ServerServiceDefinition> getServiceDefinition);
}

This change enables to map gRPC services via Grpc.Core.ServerServiceDefinition, therefore migration from Grpc.Core can be more easier.

Describe alternatives you've considered

This commit contains concrete code as far as I can write, but I do not care about these implementations.
I welcome better ways to realize this suggestion.

Additional context

No response

…ServerServiceDefinition (#1)

* support MapGrpcService with ServerServiceDefinition

* support MapGrpcService with ServerServiceDefinition

* rename sample solution file

* create factory method

* remove extra using

* fix sample project for ServerServiceDefinition mapping

* implement Metadata creation for ServerServiceDefinition

* implement unit test for MapGrpcService for ServerServiceDefinition

---------

Co-authored-by: aka-nse <nakased.1220@gmail.com>
Copy link

linux-foundation-easycla bot commented Sep 15, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant