Support 'Rename' Option

[elsbree]

I'm attempting to configure a task that compresses all the files in a directory, and leaves their file extensions intact.

I've defined my compress config as follows:

compress: {
    options: {
        mode: 'gzip',
        pretty: true
    },
    dev: {
        expand: true,
        cwd: 'public/',
        src: '**/*',
        dest: 'dist/dev',
        rename: function(dest, src) {
            var out = dest + '/' + src;
            out = out.replace('.gz', '');

            grunt.log.writeln(out);

            return out;
        }
    },
},

But when I run compress:dev, I see the following log output:
(just a short snippet as an example)

dist/dev/stylesheets/var/template/themes/shifty.css
dist/dev/stylesheets/var/template/themes/squary.css
dist/dev/stylesheets/var/template/themes/stacky-fat.css
dist/dev/stylesheets/var/template/themes/stacky-tall.css
Created dist/dev/stylesheets/var/template/themes/shifty.css.gz (2.9 kB)
Created dist/dev/stylesheets/var/template/themes/squary.css.gz (2.4 kB)
Created dist/dev/stylesheets/var/template/themes/stacky-fat.css.gz (3.1 kB)
Created dist/dev/stylesheets/var/template/themes/stacky-tall.css.gz (2.9 kB)

The correct values are being returned from the rename function, but the output files' names are not changed. Is the rename function not supported in grunt-contrib-compress, or am I missing something?

[netpro2k]

The issue is not that rename isnt supported, but rather that the task automatically applies a default extension reguardless of if you have a rename function or not. I tried specifying a blank "ext" but that gives no extension, and specifiying the original extension (say ".js") causes issues with files with multiple dots in the name (#67)

I created a commit for my own use that simply removes automatic extension adding, but I doubt it would be accepted as a PR: netpro2k@7c7e695

[tkellen]

@netpro2k I agree that the extension should be handled by ext or rename. Please submit that PR.

[tkellen]

Also, re #67, see the extDot option:
http://gruntjs.com/configuring-tasks#building-the-files-object-dynamically

[tkellen]

@ctalkington Is there any reason this code can't go?
netpro2k@7c7e695

[ctalkington]

hum, dont think that is code that I did but im all for using grunt features where possible.

[btilford]

This extension is essentially useless for gziping css/js whithout this fixed. Extremely common things like version numbers or .min.js completely break the plugin.

[trullock]

+1 for not renaming by default

[ctalkington]

@vladikoff think this has been merged?

[vladikoff]

Yeap!