fix: Removing i18next-browser-languagedetector from the shared depend…

…encies (#142)
gsoft-inc · Jan 29, 2024 · 524be12 · 524be12
1 parent 09123cb
commit 524be12
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 20 deletions.
diff --git a/.changeset/smart-horses-deny.md b/.changeset/smart-horses-deny.md
@@ -0,0 +1,5 @@
+---
+"@squide/webpack-configs": patch
+---
+
+Removing `i18next-browser-languagedetector` from the shared dependencies as it causing an Error at runtime.
diff --git a/packages/webpack-configs/src/defineConfig.ts b/packages/webpack-configs/src/defineConfig.ts
@@ -74,14 +74,16 @@ function getI18nextSharedDependency(isHost: boolean): ModuleFederationSharedOpti
             singleton: true,
             eager: isHost ? true : undefined
         },
+        // Not adding as a shared dependency for the moment because it causes the following error:
+        // Uncaught (in promise) TypeError: i18next_browser_languagedetector__WEBPACK_IMPORTED_MODULE_3__ is not a constructor
+        // "i18next-browser-languagedetector": {
+        //     singleton: true,
+        //     eager: isHost ? true : undefined
+        // },
         "react-i18next": {
             singleton: true,
             eager: isHost ? true : undefined
         },
-        "i18next-browser-languagedetector": {
-            singleton: true,
-            eager: isHost ? true : undefined
-        },
         "@squide/i18next": {
             singleton: true,
             eager: isHost ? true : undefined

diff --git a/packages/webpack-configs/tests/__snapshots__/defineConfig.test.ts.snap b/packages/webpack-configs/tests/__snapshots__/defineConfig.test.ts.snap
@@ -162,10 +162,6 @@ exports[`defineBuildHostConfig when i18next is activated, add i18next shared dep
           "eager": true,
           "singleton": true,
         },
-        "i18next-browser-languagedetector": {
-          "eager": true,
-          "singleton": true,
-        },
         "react": {
           "eager": true,
           "requiredVersion": false,
@@ -482,10 +478,6 @@ exports[`defineBuildRemoteModuleConfig when i18next is activated, add i18next sh
           "eager": undefined,
           "singleton": true,
         },
-        "i18next-browser-languagedetector": {
-          "eager": undefined,
-          "singleton": true,
-        },
         "react": {
           "eager": undefined,
           "requiredVersion": false,
@@ -781,10 +773,6 @@ exports[`defineDevHostConfig when i18next is activated, add i18next shared depen
           "eager": true,
           "singleton": true,
         },
-        "i18next-browser-languagedetector": {
-          "eager": true,
-          "singleton": true,
-        },
         "react": {
           "eager": true,
           "requiredVersion": false,
@@ -1101,10 +1089,6 @@ exports[`defineDevRemoteModuleConfig when i18next is activated, add i18next shar
           "eager": undefined,
           "singleton": true,
         },
-        "i18next-browser-languagedetector": {
-          "eager": undefined,
-          "singleton": true,
-        },
         "react": {
           "eager": undefined,
           "requiredVersion": false,