Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in GUAC REST Server description #149

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

ANIRUDH-333
Copy link

No description provided.

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for resonant-wisp-1a517a ready!

Name Link
🔨 Latest commit e55011a
🔍 Latest deploy log https://app.netlify.com/sites/resonant-wisp-1a517a/deploys/66ed8e3f7451a60008ede1eb
😎 Deploy Preview https://deploy-preview-149--resonant-wisp-1a517a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@funnelfiasco
Copy link
Collaborator

funnelfiasco commented Sep 20, 2024

Thanks for the contribution, @ANIRUDH-333! These changes look good to me. You will need to include a Developer Certificate of Origin signoff in order for us to merge these changes. I suggest squashing your two commits into one when you add the signoff, but that's not required. If you need help with that, you can message me in the #guac channel on OpenSSF Slack. See the community page for details if you need it.

@funnelfiasco funnelfiasco added bug Something isn't working documentation Improvements or additions to documentation labels Sep 20, 2024
Signed-off-by: Anirudh Edpuganti <aniedpuganti@gmail.com>
@ANIRUDH-333
Copy link
Author

Thanks for the contribution, @ANIRUDH-333! These changes look good to me. You will need to include a Developer Certificate of Origin signoff in order for us to merge these changes. I suggest squashing your two commits into one when you add the signoff, but that's not required. If you need help with that, you can message me in the #guac channel on OpenSSF Slack. See the community page for details if you need it.

Thank you @funnelfiasco for the suggestion. I have squashed the commits and added DCO also. Can you please review it now?

Copy link
Collaborator

@funnelfiasco funnelfiasco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank You!

@pxp928 pxp928 merged commit dacc67a into guacsec:main Sep 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants