Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dependency on goreleaser #71

Merged
merged 1 commit into from
Jul 5, 2023
Merged

add dependency on goreleaser #71

merged 1 commit into from
Jul 5, 2023

Conversation

j-white
Copy link
Contributor

@j-white j-white commented Jul 3, 2023 •
edited
Loading

I was trying to build the latest main and got hit with this:

% make container                                                                                     
goreleaser is not installed. Please install goreleaser and try again.                                                    
make: *** [check-goreleaser-tool-check] Error 1

Looks like we made the dependency explicit here: guacsec/guac@fcedbd0#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52L100

@netlify
Copy link

netlify bot commented Jul 3, 2023 •
edited
Loading

✅ Deploy Preview for resonant-wisp-1a517a ready!

Name Link
🔨 Latest commit c83ca84
🔍 Latest deploy log https://app.netlify.com/sites/resonant-wisp-1a517a/deploys/64a23271e6c93a0008e13989
😎 Deploy Preview https://deploy-preview-71--resonant-wisp-1a517a.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@j-white
add dependency on goreleaser
c83ca84 
Signed-off-by: Jesse White <jwhite08@gmail.com>
pxp928
pxp928 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank You!

@lumjjb lumjjb merged commit ab55e6d into guacsec:main Jul 5, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumjjb lumjjb lumjjb approved these changes

@pxp928 pxp928 pxp928 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-white @lumjjb @pxp928