fix vim editing (Linux) + group related fs events #212
Conversation
e2
commented
Apr 16, 2014
e2
commented
- Linux/inotify: relies on close_write where attribs are not updated (e.g. ecryptfs)
- all local adapters: logically groups related fs events into single changes (or skips them completely)
- avoids notifying multiple events per file
- fix tests to more consistently use Pathname instead of strings
- additional tests for _smoosh_changes to test for and handle various editor-related differences in the future
- use "shift" instead of "pop" to process received events in order (for whatever future reason)
- treat "mv a x && mv x a" like "touch a"
- Linux/inotify: relies on close_write where attribs are not updated (e.g. ecryptfs) - all local adapters: logically groups related fs events into single changes (or skip them completely) - avoids notifying multiple events per file - fix tests to more consistently use Pathname instead of strings - additional tests for _smoosh_changes to test for and handle various editor-related differences in the future - use "shift" instead of "pop" to process received events in order (for whatever future reason)
| end | ||
|
|
||
| def _local_fs? | ||
| not registry[:adapter].is_a? Adapter::TCP |
There was a problem hiding this comment.
I try to follow bbatsov Ruby style guideline, please could you change it to: !registry[:adapter].is_a?(Adapter::TCP)
|
Looks good, like the logic! 👍 |
|
No - problem. This pull request is for review mostly, so don't hold back on what changes you want, separate commits, edge case or any syntax/conventions/compatibility issues. Thanks! P.S. I'm mostly worried about directory handling and/or other caveats, since I personally can't think of good use cases with Guard/listen. And other use cases that could have been relying on the previous behavior. P.S.2. I don't mind being mentioned on related Linux/Vim issues if that helps nail/close those issues. |
|
I created a special branch that helps debugging issues related to watching/responding to changes (+showing inotify events specifically). How to use: If anyone reproduces their problem with this branch of listen, the output should making finding identifying and fixing the cause (listen, adapter, guard or plugin) easy. And closing issues too. |
|
#215 replaces this PR |
