Add headingStyle and replace title

guardian · Sep 17, 2024 · d376bc6 · d376bc6
1 parent 4ee1171
commit d376bc6
Show file tree

Hide file tree

Showing 2 changed files with 59 additions and 2 deletions.
diff --git a/proto/blueprint.proto b/proto/blueprint.proto
@@ -96,11 +96,30 @@ message Collection {
    * the header is rendered in smaller size to show they are child
    * sections within a main collection.
    */
-  optional bool small_heading = 16;
+  optional bool small_heading = 16 [deprecated = true];
 
   optional AdTargetingParams ad_targeting_params = 17;
 
   optional string ad_unit = 18;
+
+  /**
+   * This tells the app in which style to display, or not display,
+   * the title.
+   */ 
+  enum HeadingStyle {
+    HEADING_STYLE_UNSPECIFIED = 0;
+    HEADING_STYLE_HIDDEN = 1;
+    HEADING_STYLE_REGULAR = 2;
+    HEADING_STYLE_SMALL = 3;
+  }
+  optional HeadingStyle headingStyle = 19;
+
+  /**
+   * The title of this collection for display.  It replaces 
+   * the old "title" property.
+   */
+  optional string displayTitle = 20;
+
 }
 
 /**

diff --git a/proto/proto.lock b/proto/proto.lock
@@ -24,6 +24,26 @@
               }
             ]
           },
+          {
+            "name": "Collection.HeadingStyle",
+            "enum_fields": [
+              {
+                "name": "HEADING_STYLE_UNSPECIFIED"
+              },
+              {
+                "name": "HEADING_STYLE_HIDDEN",
+                "integer": 1
+              },
+              {
+                "name": "HEADING_STYLE_REGULAR",
+                "integer": 2
+              },
+              {
+                "name": "HEADING_STYLE_SMALL",
+                "integer": 3
+              }
+            ]
+          },
           {
             "name": "FollowUp.FollowUpType",
             "enum_fields": [
@@ -413,7 +433,13 @@
                 "id": 16,
                 "name": "small_heading",
                 "type": "bool",
-                "optional": true
+                "optional": true,
+                "options": [
+                  {
+                    "name": "deprecated",
+                    "value": "true"
+                  }
+                ]
               },
               {
                 "id": 17,
@@ -426,6 +452,18 @@
                 "name": "ad_unit",
                 "type": "string",
                 "optional": true
+              },
+              {
+                "id": 19,
+                "name": "headingStyle",
+                "type": "HeadingStyle",
+                "optional": true
+              },
+              {
+                "id": 20,
+                "name": "displayTitle",
+                "type": "string",
+                "optional": true
               }
             ]
           },