Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add commercial fields to the blueprint response #108

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

lindseydew
Copy link
Contributor

What does this change?

This adds the ad_targeting_params and ad_unit field to blueprint collections response as currently we are serving these in the legacy collections endpoint, but not in the new blueprint one. These fields are needed for advertising

How to test

How can we measure success?

Have we considered potential risks?

Images

Accessibility

@lindseydew lindseydew requested a review from a team as a code owner September 17, 2024 13:41
Copy link
Contributor

@waisingyiu waisingyiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lindseydew lindseydew merged commit b95b907 into main Sep 17, 2024
2 checks passed
@lindseydew lindseydew deleted the ld/commercial-data-to-blueprint-collections branch September 17, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants