Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add show quoted headline field to article object #34

Merged
merged 5 commits into from
Jul 31, 2023

Conversation

silvacb
Copy link
Contributor

@silvacb silvacb commented Jul 27, 2023

What does this change?

In the fronts tool, the card configuration allows editors to choose whether a card’s headline should be quoted. On web and prod app, if this toggle is selected then the headline should appear in quotes.

We need to make sure this behaviour is the same on blueprint fronts by including an additional boolean field in the schema to represent article configuration: show_quoted_headline.

MAPI should be returning this field in accordance with the data we get from the fronts tool and the client should be using the boolean property to determine when to show quoted headline.

@silvacb silvacb requested a review from DavidLawes July 27, 2023 10:23
Copy link
Contributor

@DavidLawes DavidLawes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks!

@silvacb silvacb marked this pull request as draft July 28, 2023 14:56
@silvacb silvacb marked this pull request as ready for review July 28, 2023 15:52
@silvacb silvacb changed the title Add show quoted headline field to card object Add show quoted headline field to article object Jul 28, 2023
@silvacb silvacb merged commit 060272a into main Jul 31, 2023
2 checks passed
@silvacb silvacb deleted the sb/add-show-quoted-headline branch July 31, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants