Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle correctly plural form, even if single plural form. #34

Merged
merged 2 commits into from
May 9, 2020

Conversation

guillaumepotier
Copy link
Owner

Should fix #33

tests/tests.js Outdated
"%1 lisaun iha."
]
}, 'nplurals=1; plural=0;');
console.log('here');

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log('here');

Copy link

@PeteCoward PeteCoward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • builds ok
  • tests all pass
  • fixes my issue \o/

rogue console.log in the tests, but that doesn't affect me :)

@guillaumepotier
Copy link
Owner Author

@PeteCoward that's a pretty neat CR ;) Thanks!

I'll remove this rogue console.log and push/publish the new version today.

Keep you posted

Best

@guillaumepotier guillaumepotier merged commit 8fee0a2 into master May 9, 2020
@guillaumepotier guillaumepotier deleted the single-plural-form branch May 9, 2020 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngettext fails on with substitutions with nplurals=1
2 participants