Update po2json dep to latest available beta version #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an npm audit failure. underscore 1.3.2 - 1.12.0 Severity: high Arbitrary Code Execution in underscore - GHSA-cf4h-3jhx-xvhq No fix available node_modules/underscore nomnom >=1.6.0 Depends on vulnerable versions of underscore node_modules/nomnom po2json 0.3.1 - 0.4.5 Depends on vulnerable versions of nomnom node_modules/po2json gettext.js >=0.3.0 Depends on vulnerable versions of po2json node_modules/gettext.js
|
Hi @whiteinge Thank you for your PR, much appreciated :) I'll think about the Best |
|
@guillaumepotier would you mind cutting a new release with the recent PR merges? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a long-standing npm audit failure. This is for a beta version but upstream has been waiting on a stable release for a while now.
As an alternate approach: what do you think about removing the
po2jsondependency completely? Instead just link to that repo in the README (similar to what #38 is proposing). I'm fuzzy on what the value-add of thebin/po2jsonwrapper script is, and we just call out to po2json directly. That removal would makegettext.jsa zero-dependency library with a stable API and with no now (or future!) NPM drama 😝 ).