[BC Break] Change the way we choose the plural form + string replacement #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaumepotier
force-pushed
the
bc-plurals
branch
from
4f79209
to
fa26f33
Compare
|
still lgtm :) |
|
Any chance of this being merged & released as a new major? |
|
Sorry @nornagon to have kept you waiting for so long :( I just merged this PR and created a brand new Best |
|
It's not on NPM :) |
|
My bad, I published it just now and it appears on npm.js https://www.npmjs.com/package/gettext.js |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #66
GNU Plural forms