Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP Options request to the client. #49

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Conversation

ArasAzimi
Copy link

@ArasAzimi ArasAzimi commented Nov 8, 2019

We are using openapi-cli-generator which uses gentleman as its http client. We need to use the options method, and that is what this PR for. Thank you

@ArasAzimi
Copy link
Author

hey @h2non, the pipeline fails on golang tip, and I have verified that the failure is happening on master before this PR as well (it is gone unnoticed since the pipeline has not run in a while). It seems like some string formatting change, which causes an assert in the TestProxyParseError to fail. Do you mind take a look?

@h2non h2non self-assigned this Nov 11, 2019
@h2non h2non merged commit df41097 into h2non:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants