Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove transfers showing on summary page #490

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

x4nk1t
Copy link

@x4nk1t x4nk1t commented Jun 20, 2024

This commit hides the transfers from showing up as income / expense.

@h-savarala
Copy link

If the selected account is excluded means it will add boolean to transaction
Can't we just use account id to remove them

@x4nk1t
Copy link
Author

x4nk1t commented Jun 23, 2024

The problem I'm facing is when I transfer balance from A -> B, it will show up as income / expenses in the summary page.
So, as you've said if we exclude the accounts it will no longer show the transaction at all.

@h4h13
Copy link
Owner

h4h13 commented Jun 23, 2024

But by using an account we're already excluding right wasn't it working

@x4nk1t
Copy link
Author

x4nk1t commented Jun 24, 2024 via email

@h-savarala
Copy link

Going forward we're treating the transfer as different item so it wont be included in sum

@x4nk1t
Copy link
Author

x4nk1t commented Jun 24, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants