Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main.css: <video> also vertical-align: middle; #1326

Closed
joeyhoer opened this issue Mar 4, 2013 · 6 comments
Closed

Main.css: <video> also vertical-align: middle; #1326

joeyhoer opened this issue Mar 4, 2013 · 6 comments
Milestone

Comments

@joeyhoer
Copy link

joeyhoer commented Mar 4, 2013

The video tag, being an inline-block level element, also suffers from a slight amount of vertical spacing due to line-height, just as the img tag does.

Just wondering if it shouldn't be given the same treatment.

@drublic
Copy link
Member

drublic commented Mar 5, 2013

Yup, sound good to me. Same goes for audio with controls and also canvas if we want to be correct I think.
This is an issue we should discuss in normalize.css. @necolas, haven't found a discussion about it in the normalize repo. Worth reporting?

@necolas
Copy link
Member

necolas commented Mar 5, 2013

This isn't appropriate for normalize because the default is baseline alignment.

@joeyhoer
Copy link
Author

joeyhoer commented Mar 7, 2013

I agree with @necolas about the inclusion (or lack thereof) in normalize.css, but I think there's definitely precedent for this in main.css. I like the idea of adding canvas and audio as well. Are there any more elements that this could also apply to (object, embed, svg), and would it be useful to add those as well?

@sureshgaju
Copy link

Yes I agree with @necolas about the normalize.css. useful to add the media library and j query library

@Alynn77
Copy link

Alynn77 commented May 3, 2013

Yea

@necolas
Copy link
Member

necolas commented Jun 1, 2013

@joeyhoer Do you want to have a go at putting together a Pull Request for this change to our main.css file?

alrra pushed a commit that referenced this issue Oct 15, 2013
Remove gap between the `svg` elements and the bottom of their containers
by vertically centering them.

Ref #1326.
Close #1453.
kcmckell pushed a commit to kcmckell/html5-boilerplate that referenced this issue Feb 25, 2014
Remove gap between the `svg` elements and the bottom of their containers
by vertically centering them.

Ref h5bp#1326.
Close h5bp#1453.
alrra pushed a commit that referenced this issue Mar 20, 2014
Remove gap between the `svg` elements and the bottom of their containers
by vertically centering them.

Ref #1326.
Close #1453.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants