Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test and demo folders #808

Closed
necolas opened this issue Oct 11, 2011 · 9 comments
Closed

Remove test and demo folders #808

necolas opened this issue Oct 11, 2011 · 9 comments
Assignees
@necolas

Comments

@necolas
Copy link
Member

necolas commented Oct 11, 2011

My guess is that the only useful demo file is elements.html...the others aren't even maintained. So we could trash the demo folder, rename elements.html to demo.html, and stick in it the root.

The qunit stuff hasn't been updated since Aug 2010, and is another thing that most people probably never use. We could remove this folder and improve the documentation/readme to encourage people to look into qunit if their situation benefits from it.

I think this cleaning up will help to reduce the appearance of complexity in the default boilerplate. If there is no objection to this, I'll get on it.
@Gavrisimo
Copy link

Sounds good to me.

@paulirish
Copy link
Member

I just updated the qunit to 1.1.0 in f1e9bb3 .. so THERE! :p

That said i can imagine a h5bp w/o a test folder. we're collecting data here now: http://gopollgo.com/do-you-use-the-qunit-test-suite-in-html5-boilerplate

demo is useful for us, but that's about it, ya. can go in a branch or something.

@ShaneShipston
Copy link

Can't say I have ever used either of the folders.

@sashasklar
Copy link

Are most people using createproject.sh? It could be an option, with the default leaving them out.

@necolas
Copy link
Member Author

necolas commented Oct 14, 2011

Poll results: 88% of respondents don't use it.

We could remove it and make mention of unit testing in the wiki, including links to the popular test suites.

@ghost ghost assigned necolas Oct 14, 2011
necolas added a commit that referenced this issue Oct 23, 2011
@necolas
Remove test folder.
0a80eba 
Over 80% of people polled are not using the qunit testing
provided. Remove it in favour of people using their unit testing
framework of choice.

Ref #808
necolas added a commit that referenced this issue Oct 23, 2011
@necolas
Remove demo folder.
1437e0f 
The demo files haven't been well maintained and are of limited
use. Remove them to simplify the boilerplate.

Ref #808
@necolas
Copy link
Member Author

necolas commented Oct 23, 2011

Both folders have been removed. If there is significant desire to have the elements.html file return in some form, then we can work it back in.

@necolas necolas closed this as completed Oct 23, 2011
moimikey pushed a commit to moimikey/html5-boilerplate that referenced this issue Jan 7, 2012
@necolas @moimikey
Remove test folder.
822c59d 
Over 80% of people polled are not using the qunit testing
provided. Remove it in favour of people using their unit testing
framework of choice.

Ref h5bp#808
moimikey pushed a commit to moimikey/html5-boilerplate that referenced this issue Jan 7, 2012
@necolas @moimikey
Remove demo folder.
6e37382 
The demo files haven't been well maintained and are of limited
use. Remove them to simplify the boilerplate.

Ref h5bp#808
@jonjaques
Copy link

@necolas Not sure if this is the where elements.html got axed, but I use it all the time!! Typically for Wordpress/CMS themes (style every element).

@necolas
Copy link
Member Author

necolas commented Aug 5, 2012

@jonjaques You can try using normalize's demo.html instead.

@jonjaques
Copy link

@necolas Good call, thank you!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@necolas necolas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@paulirish @sashasklar @Gavrisimo @necolas @ShaneShipston @jonjaques