Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility note: "AddOutputFilterByType" is still a core module in Apache 2.2 #1257

Closed
wants to merge 1 commit into from

Conversation

fhemberger
Copy link
Contributor

See issue #1256.

This adds at least a compatibility notice for Apache < 2.3.7.

There may be also two alternatives to improve this check further:
a) Check the API_VERSIONof the httpd module (docs):

# API Version for first Apache 2.3.7 dev release
<If "%{API_VERSION} -lt 20100609">
    # AddOutputFilterByType …
</If>

While this is documented, it didn't work on my default Apache on OS X Snow Leopard (v.2.2.2).

b) Check the version number with mod_version:

<IfModule mod_version.c>
    <IfVersion < 2.3.7>
        # AddOutputFilterByType …
    </IfVersion>
</IfModule>

but I'm not sure if mod_version is normally installed on production environments.

@alrra
Copy link
Member

alrra commented Nov 18, 2012

a) ... While this is documented, it didn't work on my default Apache on OS X Snow Leopard (v.2.2.2).

That is because the <If> directive was introduced starting with Apache v2.4.

b) Check the version number with mod_version:

mod_version doesn't bring any value over mod_filter, in both cases the user needs to enable 1 more module (plus, I think mod_filter is more useful then mod_version, which only has the IfVersion directive and you kinda have to duplicate the code - see #1012).


@fhemberger merged, thank you! (hope you don't mind that I've modified the commit to make it a bit more clearer).

@alrra alrra closed this Nov 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants