Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update js/plugins.js #1262

Closed
wants to merge 1 commit into from
Closed

Update js/plugins.js #1262

wants to merge 1 commit into from

Conversation

saadshams
Copy link

had serious issues on IE 8, it gave me hard time even on if(window.console), try catch resolved it
it's the same issue described in here http://benwong.me/javascript-console-log-and-internet-explorer/

had serious issues on IE 8, it gave me hard time even on if(window.console), try catch resolved it
it's the same issue described in here http://benwong.me/javascript-console-log-and-internet-explorer/
@drublic
Copy link
Member

drublic commented Nov 23, 2012

Thanks for reporting @saadshams. We have tested this method heavily in IE as we want to work around the bug that are described in the link you've posted. Just lately we have discussed this in #1229.

Here is a test case. "Test with new stub" should be all green in IE8 when the code is working. Can you please verify this?
I have just tested this again and it works for me.

If there is no other bug with your code, can you please post a reduced test case of this failure? Thank you.

@necolas
Copy link
Member

necolas commented Nov 25, 2012

Have you had a chance to look at this again, @saadshams?

@necolas
Copy link
Member

necolas commented Nov 27, 2012

Closing due to lack of follow up details and our inability to reproduce the issue.

@necolas necolas closed this Nov 27, 2012
@saadshams
Copy link
Author

Hi:

Sorry I've been away for a while, it's not just one version of IE 8, there are subversion and a release for which I don't have access to.

It gave me really hard time for a client project, and that client had this specific version of IE 8 on all of their machines.

The code works really fine on our systems internally but when it goes to client, it didn't work.

Later we saw the debug message (yellow exclamation mark) that identified console as the culprit.

though I can see the issue has been closed and there's no demo I can provide but I strongly advise to watch this out for.

I'll sure let you know if I have access to that machine to find out the exact version of IE 8.

Thanks,
Saad

Date: Fri, 23 Nov 2012 03:13:58 -0800
From: notifications@github.com
To: html5-boilerplate@noreply.github.com
CC: saadshams@hotmail.com
Subject: Re: [html5-boilerplate] Update js/plugins.js (#1262)

Thanks for reporting @saadshams. We have tested this method heavily in IE as we want to work around the bug that are described in the link you've posted. Just lately we have discussed this in #1229.

Here is a test case. "Test with new stub" should be all green in IE8 when the code is working. Can you please verify this?

I have just tested this again and it works for me.

If there is no other bug with your code, can you please post a reduced test case of this failure? Thank you.

          —

          Reply to this email directly or view it on GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants