PR for #1367: Use one apple-touch-icon instead of six #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes five Apple Touch Icons with different sizes for the same icon and adds a new icon `apple-touch-icon-precomposed.png` with a resolution of 152x152px. Apart from that it adds documentation on how to add more icons if you need them within your project. Using only one Apple Touch Icon saves time and is enough in most cases. Closes #1367. Closes #1425.
|
LGTM! Nice job. Feel free to apply this to |
|
Thanks for merging, @mathiasbynens. Can we do a 4.3.0 release? |
kcmckell
pushed a commit
to kcmckell/html5-boilerplate
that referenced
this pull request
Feb 25, 2014
This commit removes five Apple Touch Icons with different sizes for the same icon and adds a new icon `apple-touch-icon-precomposed.png` with a resolution of 152×152px. Apart from that it adds documentation on how to add more icons if you need them within your project. Using only one Apple Touch Icon saves time and is enough in most cases. Closes h5bp#1367. Closes h5bp#1425.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes five Apple Touch Icons with different sizes for the same icon and adds a new icon
apple-touch-icon-precomposed.pngwith a resolution of 152x152px.Apart from that it adds documentation on how to add more icons if you need them within your project.
Using only one Apple Touch Icon saves time and is enough in most cases.
This Pull Request targets #1367.
Please keep the discussion within #1367.