Skip to content

Commit

Permalink
fix TODO to reference issue
Browse files Browse the repository at this point in the history
  • Loading branch information
rootjalex committed Feb 1, 2021
1 parent 1be801a commit 6fa0a56
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/Bounds.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -402,7 +402,7 @@ class Bounds : public IRVisitor {
// Assume no overflow for float, int32, and int64
if (op->type.can_overflow()) {
if (interval.has_upper_bound()) {
// TODO(rootjalex): Can't catch overflow of UInt(64) currently.
// TODO(5682): Can't catch overflow of UInt(64) currently.
Type t = op->type.is_uint() ? UInt(64) : Int(32);
Expr no_overflow = (cast(t, a.max) + cast(t, b.max) == cast(t, interval.max));
if (!can_prove(no_overflow)) {
Expand All @@ -411,7 +411,7 @@ class Bounds : public IRVisitor {
}
}
if (interval.has_lower_bound()) {
// TODO(rootjalex): Can't catch overflow of UInt(64) currently.
// TODO(5682): Can't catch overflow of UInt(64) currently.
Type t = op->type.is_uint() ? UInt(64) : Int(32);
Expr no_overflow = (cast(t, a.min) + cast(t, b.min) == cast(t, interval.min));
if (!can_prove(no_overflow)) {
Expand Down Expand Up @@ -526,7 +526,7 @@ class Bounds : public IRVisitor {
if (a.is_bounded() && b.is_bounded()) {
// Try to prove it can't overflow. (Be sure to use uint32 for unsigned
// types so that the case of 65535*65535 won't misleadingly fail.)
// TODO(rootjalex): Can't catch overflow of UInt(64) currently.
// TODO(5682): Can't catch overflow of UInt(64) currently.
Type t = op->type.is_uint() ? UInt(64) : Int(32);
Expr test1 = (cast(t, a.min) * cast(t, b.min) == cast(t, a.min * b.min));
Expr test2 = (cast(t, a.min) * cast(t, b.max) == cast(t, a.min * b.max));
Expand Down

0 comments on commit 6fa0a56

Please sign in to comment.