62 Adds IMU as input to cartographer and removed as input to ekf filter #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nancyhong123
requested review from
jackguo380,
divyabudihal,
hannahvsawiuk and
zhaoshengEE
jackguo380
reviewed
Mar 20, 2020
jackguo380
approved these changes
Mar 21, 2020
nancyhong123
changed the title
nancyhong123
changed the title
divyabudihal
approved these changes
Mar 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves performance of mapping when robot makes large rotations
However, the changes made in this issue will not accurately simulate an IMU in the real world as the current simulated IMU measurements are generated by a ModelPlugin (the correct implementation is to use a SensorPlugin). This problem will be addressed in issue #132
Closes #62