Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mani_skill.examples.demo_reset_distribution is not executable #312

Closed
BXZZcj opened this issue May 3, 2024 · 3 comments · Fixed by #313
Closed

mani_skill.examples.demo_reset_distribution is not executable #312

BXZZcj opened this issue May 3, 2024 · 3 comments · Fixed by #313
Assignees
Labels
bug Something isn't working

Comments

@BXZZcj
Copy link

BXZZcj commented May 3, 2024

The script 'python mani_skill.examples.demo_reset_distribution' is not executable.

I ran the command "python -m mani_skill.examples.demo_reset_distribution -e "PegInsertionSide-v1"" following the instructions in the ManiSkill3 documentation (https://maniskill.readthedocs.io/en/latest/user_guide/demos/index.html#gpu-simulation), and encountered the following errors:

AttributeError: 'PegInsertionSideEnv' object has no attribute 'render_images' 

Even after changing the env_id from "PegInsertionSide-v1" to "StackCube-v1", the error persists.

@BXZZcj BXZZcj closed this as completed May 3, 2024
@BXZZcj BXZZcj reopened this May 3, 2024
@StoneT2000 StoneT2000 added the bug Something isn't working label May 3, 2024
@StoneT2000 StoneT2000 self-assigned this May 3, 2024
@StoneT2000
Copy link
Member

StoneT2000 commented May 3, 2024

Looks like documentation wrong / script could be a bit more robust.

To fix you have to pass in

--record-dir=videos

In addition to the environment ID, then it should save a video of sampled initial states

@BXZZcj
Copy link
Author

BXZZcj commented May 3, 2024

Looks like documentation wrong / script could be a bit more robust.

To fix you have to pass in

--record-dir=videos

In addition to the environment ID, then it should save a video of sampled initial states

Thank you for your reply. That fixes the error.

My bad. I didn't carefully read the code before. "--render-mode="sensors"" is needed for the GUI. But perhaps that parameter should be added to the corresponding command as shown in the document. Thank you.

@StoneT2000
Copy link
Member

I think smth we need to fix is to try and get all example scripts to have the same arguments, they are currently all standalone scripts so there are some discrepancies. Thanks again for finding the bug!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants