-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doubled window buttons on new Chrome v94 and Firefox #254
Comments
same problem.looks like chrome dropped system frame button support. |
It would be great not to show buttons when using GTK 3+ applications (such as nautilus). |
Same issue here. Apparently, Chrome 94 broke the "Use system title bar and borders" option in settings (read more here), but one can get around that but enabling the However, even after reenabling the "Use system title bar and borders" feature, the Unite extension still shows duplicate window buttons. Not sure if the two issues are related, but it'd be great if anyone has a solution or a possible fix, thanks! |
Ok, after digging into the code and doing some debugging, I have found what I think is the root of the issue. It looks like the new versions of Chrome are reporting themselves as client side-decorated windows -- the check for At this point, I can't tell whether this is a Chrome bug or if that is the intentional behavior moving forward. Either way, I have solved the issue by adding a list of hardcoded applications for which to ignore the client side-decorated information. Ideally, we would make this a configurable setting, so that other apps could be dynamically added to the list. See polmes@2c5927c for my hotfix. Not making a PR since I do not think that is a long-term solution and is likely to break setups for users who do not enable the "Use system title bar and borders" feature in Chrome. |
Hi @polmes, thank you for the info. You can try the solution below, it works with chromium where "Use system title bar and borders" is not broken. get clientDecorated() {
return this.win.is_client_decorated() && !this.win.decorated
} I haven't tested this with many apps to see if it breaks anything.
I have created issue #82 that can help fix issues on individual apps, but I haven't found time to work on it. |
Oh, that's a nice and simple solution hahaha -- I have switched to your fix and will report back if I encounter any issues. Thanks! |
Not sure whether this is the same bug I'm having in Chromium. The titlebar as a whole (not just the buttons) does not hide: https://imgur.com/a/LZhTjXt |
Hi @sanwablo, it is the same issue. Chrome just has an extra bug with "Use system title bar and borders" not working, check #254 (comment). |
This solution didn't work for me. I am using Chrome Version 94.0.4606.81 (Official Build) (64 bits) |
Latest Brave Browser version works again! I guess next versions of Chrome/Chromium will work too. |
The issue has been fixed in chrome/chromium v95 |
Hi all, After update google chrome to version 94 on all my stations with Ubutnu 20.04 LTS (~10 computers), windows button in maximized windows is doubled on chrome gtk theme.
The same problem it can be seen on firefox for some time, but my primary browser is chrome.
Anybody know how to fix it? I used latest version of this extension: v55.
screenshot:
https://imgur.com/a/rQsyLsI
The text was updated successfully, but these errors were encountered: