Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubled window buttons on new Chrome v94 and Firefox #254

Closed
petrmatula190 opened this issue Sep 22, 2021 · 11 comments
Closed

Doubled window buttons on new Chrome v94 and Firefox #254

petrmatula190 opened this issue Sep 22, 2021 · 11 comments

Comments

@petrmatula190
Copy link

Hi all, After update google chrome to version 94 on all my stations with Ubutnu 20.04 LTS (~10 computers), windows button in maximized windows is doubled on chrome gtk theme.

The same problem it can be seen on firefox for some time, but my primary browser is chrome.

Anybody know how to fix it? I used latest version of this extension: v55.

screenshot:
https://imgur.com/a/rQsyLsI

@popykunju
Copy link

same problem.looks like chrome dropped system frame button support.

@Alter-RK
Copy link

Alter-RK commented Sep 23, 2021

It would be great not to show buttons when using GTK 3+ applications (such as nautilus).
Thus organized in this extension: https://extensions.gnome.org/extension/2015/no-title-bar-forked/

@polmes
Copy link

polmes commented Sep 26, 2021

Same issue here. Apparently, Chrome 94 broke the "Use system title bar and borders" option in settings (read more here), but one can get around that but enabling the #use-ozone-platform flag. The upstream issue has already been fixed in newer versions.

However, even after reenabling the "Use system title bar and borders" feature, the Unite extension still shows duplicate window buttons. Not sure if the two issues are related, but it'd be great if anyone has a solution or a possible fix, thanks!

@polmes
Copy link

polmes commented Sep 26, 2021

Ok, after digging into the code and doing some debugging, I have found what I think is the root of the issue. It looks like the new versions of Chrome are reporting themselves as client side-decorated windows -- the check for is_client_decorated() on the window object always returns false no matter whether the "Use system title bar and borders" option is enabled or not.

At this point, I can't tell whether this is a Chrome bug or if that is the intentional behavior moving forward. Either way, I have solved the issue by adding a list of hardcoded applications for which to ignore the client side-decorated information. Ideally, we would make this a configurable setting, so that other apps could be dynamically added to the list.

See polmes@2c5927c for my hotfix. Not making a PR since I do not think that is a long-term solution and is likely to break setups for users who do not enable the "Use system title bar and borders" feature in Chrome.

@jonian
Copy link
Member

jonian commented Sep 26, 2021

Hi @polmes, thank you for the info. You can try the solution below, it works with chromium where "Use system title bar and borders" is not broken.

get clientDecorated() {
  return this.win.is_client_decorated() && !this.win.decorated
}

I haven't tested this with many apps to see if it breaks anything.

Either way, I have solved the issue by adding a list of hardcoded applications for which to ignore the client side-decorated information. Ideally, we would make this a configurable setting, so that other apps could be dynamically added to the list.

I have created issue #82 that can help fix issues on individual apps, but I haven't found time to work on it.

@polmes
Copy link

polmes commented Sep 26, 2021

Oh, that's a nice and simple solution hahaha -- I have switched to your fix and will report back if I encounter any issues. Thanks!

@sanwablo
Copy link

sanwablo commented Oct 12, 2021

Not sure whether this is the same bug I'm having in Chromium.

The titlebar as a whole (not just the buttons) does not hide: https://imgur.com/a/LZhTjXt

@jonian
Copy link
Member

jonian commented Oct 12, 2021

Hi @sanwablo, it is the same issue. Chrome just has an extra bug with "Use system title bar and borders" not working, check #254 (comment).

@BenjiSan
Copy link

BenjiSan commented Oct 17, 2021

This solution didn't work for me. I am using Chrome Version 94.0.4606.81 (Official Build) (64 bits)

@jonian
Copy link
Member

jonian commented Oct 19, 2021

Latest Brave Browser version works again! I guess next versions of Chrome/Chromium will work too.

@jonian
Copy link
Member

jonian commented Oct 20, 2021

The issue has been fixed in chrome/chromium v95

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants