Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add load balancer and IP pool docs #323

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

yaocw2020
Copy link
Contributor

Related issue: harvester/harvester#2134

@netlify
Copy link

netlify bot commented May 29, 2023

Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit 67d6627
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/64d761bda7c8d10008c727da
😎 Deploy Preview https://deploy-preview-323--harvester-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@vickyhella vickyhella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only some nits ^^

docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed for style and grammar.

docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
Copy link
Contributor

@vickyhella vickyhella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yaocw2020
Copy link
Contributor Author

yaocw2020 commented Jul 11, 2023

I add more details about IP pool in the second commit. Please help review it, thanks. @vickyhella @LucasSaintarbor @guangbochen

docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/rancher/cloud-provider.md Outdated Show resolved Hide resolved
docs/rancher/cloud-provider.md Outdated Show resolved Hide resolved
docs/rancher/cloud-provider.md Outdated Show resolved Hide resolved
docs/rancher/cloud-provider.md Outdated Show resolved Hide resolved
docs/rancher/cloud-provider.md Outdated Show resolved Hide resolved
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small NITs. LGTM 👍

Note: Opening separate PR in the future to reformat other parts of these pages.

docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
docs/rancher/cloud-provider.md Outdated Show resolved Hide resolved
docs/rancher/cloud-provider.md Outdated Show resolved Hide resolved
docs/rancher/cloud-provider.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/ippool.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Outdated Show resolved Hide resolved
docs/networking/loadbalancer.md Show resolved Hide resolved
docs/networking/loadbalancer.md Show resolved Hide resolved
docs/rancher/cloud-provider.md Show resolved Hide resolved
docs/rancher/cloud-provider.md Outdated Show resolved Hide resolved
Signed-off-by: Canwu Yao <yaocanwu@gmail.com>
Co-authored-by: vickyhella <vickyhella@hotmail.com>
Co-authored-by: Lucas Saintarbor <lucas.saintarbor@suse.com>
Co-authored-by: Guangbo <guangbo.chen@suse.com>
Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@guangbochen guangbochen merged commit c8934f9 into harvester:main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants