Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add select a node before migration #345

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

chrisho
Copy link
Contributor

@chrisho chrisho commented Jun 26, 2023

Description:
Describe the matching rules for selecting nodes before migration.

Related issue:
harvester/harvester#3032

Backend code PR:
harvester/harvester#3399

@netlify
Copy link

netlify bot commented Jun 26, 2023

Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit 35b4af5
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/64a7bb3c92479b000830be10
😎 Deploy Preview https://deploy-preview-345--harvester-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lmk if these changes are okay. Thanks!

docs/vm/live-migration.md Outdated Show resolved Hide resolved
docs/vm/live-migration.md Outdated Show resolved Hide resolved
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit 👍

docs/vm/live-migration.md Outdated Show resolved Hide resolved
Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfer to move the doc to the section as below
image

Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change to use "target nodes" terms from UI

docs/vm/live-migration.md Outdated Show resolved Hide resolved
Co-authored-by: Lucas Saintarbor <lucas.saintarbor@suse.com>
@guangbochen guangbochen merged commit 1aa3fbf into harvester:main Jul 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants