-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add section about image cleaning for disk space #348
Conversation
✅ Deploy Preview for harvester-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@starbops If these changes are okay, I'll add them to v1.1. Thanks!
Signed-off-by: Zespre Chang <zespre.chang@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applied suggestions from @starbops and small nics. LGTM 👍
@LucasSaintarbor, I've updated the docs based on your suggestions. Thank you! |
docs/faq.md
Outdated
To recover from this state, do one of the following depending on the cluster's configuration: | ||
- Pull the missing images from sources outside of the cluster (if it's an air-gapped environment, you might need to set up an HTTP proxy beforehand). | ||
- Manually import the images from the Harvester ISO image. | ||
- Find the missing images on one node on the other nodes, and then export the images from the node still with them and import them on the missing one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Find the missing images on one node on the other nodes, and then export the images from the node still with them and import them on the missing one. | |
- Find the missing images on that node from the other nodes, then export the images from the node where the images still exist and import it on the missing node. |
|
||
To recover from this state, do one of the following depending on the cluster's configuration: | ||
- Pull the missing images from sources outside of the cluster (if it's an air-gapped environment, you might need to set up an HTTP proxy beforehand). | ||
- Manually import the images from the Harvester ISO image. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can u specify how to do that or link to a proper doc/script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated it with a side note about how to achieve that. PTAL, thanks.
Adding @starbops feedback Co-authored-by: Zespre Chang <zespre.chang@suse.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
* Add section about image cleaning for disk space Signed-off-by: Zespre Chang <zespre.chang@suse.com> * Update docs/faq.md Adding @starbops feedback Co-authored-by: Zespre Chang <zespre.chang@suse.com> --------- Signed-off-by: Zespre Chang <zespre.chang@suse.com> Co-authored-by: Lucas Saintarbor <lucas.saintarbor@suse.com>
Related issue: harvester/harvester#2132
P.S. The link in the article will be valid after the PR harvester/upgrade-helpers#6 is merged.