Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section about image cleaning for disk space #348

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

starbops
Copy link
Member

@starbops starbops commented Jul 10, 2023

Related issue: harvester/harvester#2132

P.S. The link in the article will be valid after the PR harvester/upgrade-helpers#6 is merged.

@netlify
Copy link

netlify bot commented Jul 10, 2023

Deploy Preview for harvester-preview ready!

Name Link
🔨 Latest commit d249e5e
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/64ccc09a94c86b0008665b51
😎 Deploy Preview https://deploy-preview-348--harvester-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@starbops If these changes are okay, I'll add them to v1.1. Thanks!

docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
@LucasSaintarbor LucasSaintarbor added this to the v1.2.0 milestone Jul 17, 2023
Signed-off-by: Zespre Chang <zespre.chang@suse.com>
Copy link
Contributor

@LucasSaintarbor LucasSaintarbor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applied suggestions from @starbops and small nics. LGTM 👍

docs/faq.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.1/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.1/faq.md Outdated Show resolved Hide resolved
versioned_docs/version-v1.1/faq.md Outdated Show resolved Hide resolved
docs/faq.md Outdated Show resolved Hide resolved
@starbops
Copy link
Member Author

@LucasSaintarbor, I've updated the docs based on your suggestions. Thank you!

@starbops starbops requested a review from bk201 July 26, 2023 03:23
docs/faq.md Outdated
To recover from this state, do one of the following depending on the cluster's configuration:
- Pull the missing images from sources outside of the cluster (if it's an air-gapped environment, you might need to set up an HTTP proxy beforehand).
- Manually import the images from the Harvester ISO image.
- Find the missing images on one node on the other nodes, and then export the images from the node still with them and import them on the missing one.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Find the missing images on one node on the other nodes, and then export the images from the node still with them and import them on the missing one.
- Find the missing images on that node from the other nodes, then export the images from the node where the images still exist and import it on the missing node.


To recover from this state, do one of the following depending on the cluster's configuration:
- Pull the missing images from sources outside of the cluster (if it's an air-gapped environment, you might need to set up an HTTP proxy beforehand).
- Manually import the images from the Harvester ISO image.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u specify how to do that or link to a proper doc/script?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated it with a side note about how to achieve that. PTAL, thanks.

Adding @starbops feedback

Co-authored-by: Zespre Chang <zespre.chang@suse.com>
Copy link
Member

@bk201 bk201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@guangbochen guangbochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@guangbochen guangbochen merged commit 2701f23 into harvester:main Aug 4, 2023
5 checks passed
vickyhella pushed a commit to vickyhella/harvester-docs that referenced this pull request Sep 4, 2023
* Add section about image cleaning for disk space

Signed-off-by: Zespre Chang <zespre.chang@suse.com>

* Update docs/faq.md

Adding @starbops feedback

Co-authored-by: Zespre Chang <zespre.chang@suse.com>

---------

Signed-off-by: Zespre Chang <zespre.chang@suse.com>
Co-authored-by: Lucas Saintarbor <lucas.saintarbor@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants