Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add canonical links for /logging #361

Merged
merged 18 commits into from
Jul 26, 2023

Conversation

LucasSaintarbor
Copy link
Contributor

Adding canonical links to /logging section pages in Harvester.

Tied to https://github.com/harvester/docs/issues/341

@netlify
Copy link

netlify bot commented Jul 14, 2023

👷 Deploy Preview for harvester-preview processing.

Name Link
🔨 Latest commit 5179ef9
🔍 Latest deploy log https://app.netlify.com/sites/harvester-preview/deploys/64c0248270b638000744c103

@vickyhella
Copy link
Contributor

vickyhella commented Jul 18, 2023

Seems like this PR brought broken links to the zh locale. I created a commit to rectify the failure (simply by renaming the corresponding zh files and the category IDs). Please take a second look and thanks for submitting those PRs!

image

Copy link
Contributor

@vickyhella vickyhella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucasSaintarbor The current modifications look good to me. If the added commit is good for you, please feel free to squash and merge this PR.

@vickyhella vickyhella merged commit 8a79741 into harvester:main Jul 26, 2023
6 checks passed
@LucasSaintarbor LucasSaintarbor deleted the canonical-logging branch July 26, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants