Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golang to v1.21 #11

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Bump golang to v1.21 #11

merged 3 commits into from
Apr 9, 2024

Conversation

votdev
Copy link
Member

@votdev votdev commented Mar 25, 2024

Problem:
Go v1.20 is EOL on 06 Feb 2024.

Solution:
Bump golang to v1.21.

Related Issue:
harvester/harvester#5310

@votdev votdev self-assigned this Mar 25, 2024
@votdev votdev force-pushed the issue_5310_go_1.21 branch 2 times, most recently from bf0e4fa to 17bc464 Compare March 26, 2024 08:59
@votdev
Bump golang to v1.21
0029dc8 
Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev
Add scripts to validate and test code locally
ec43f37 
Signed-off-by: Volker Theile <vtheile@suse.com>
@votdev votdev marked this pull request as ready for review March 26, 2024 12:46
@bk201
Copy link
Member

bk201 commented Mar 27, 2024

@Vicente-Cheng Will this cause an issue when importing the package from v1.2 components?

@FrankYang0529
Copy link
Member

@Vicente-Cheng Will this cause an issue when importing the package from v1.2 components?

Hi @bk201, I just created a draft PR in harvester-installer to use the change in this PR. We can see whether CI can pass. If it can, I think it's good to merge this PR. Thanks.

harvester/harvester-installer#696

@FrankYang0529
Copy link
Member

@Vicente-Cheng Will this cause an issue when importing the package from v1.2 components?

Hi @bk201, I just created a draft PR in harvester-installer to use the change in this PR. We can see whether CI can pass. If it can, I think it's good to merge this PR. Thanks.

harvester/harvester-installer#696

It looks like we have a package issue about "slices". Do we want to make a branch in go-common for v1.2?

@Vicente-Cheng
scripts: remove version
98f21ce 
    - we should not need this for lint/test

Signed-off-by: Vicente Cheng <vicente.cheng@suse.com>
@Vicente-Cheng
Copy link
Collaborator

Hi @votdev, I removed the version because we should not need it for test/lint.
Feel free to update any opinions when you get back. Thanks!

FrankYang0529
FrankYang0529 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@FrankYang0529 FrankYang0529 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the upgrade.

@Vicente-Cheng Vicente-Cheng merged commit eb8883e into harvester:main Apr 9, 2024
3 checks passed
@FrankYang0529
Copy link
Member

@mergify backport v1.2.x

1 similar comment
@FrankYang0529
Copy link
Member

@mergify backport v1.2.x

@mergify Mergify
Copy link

mergify bot commented Apr 17, 2024 •
edited
Loading

backport v1.2.x

✅ Backports have been created

@mergify mergify bot mentioned this pull request Apr 17, 2024
Merged
@votdev votdev deleted the issue_5310_go_1.21 branch May 21, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vicente-Cheng Vicente-Cheng Vicente-Cheng approved these changes

@FrankYang0529 FrankYang0529 FrankYang0529 approved these changes

@bk201 bk201 Awaiting requested review from bk201

Assignees

@votdev votdev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@votdev @bk201 @FrankYang0529 @Vicente-Cheng