-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HIP-367 : Remove Token Association Limit #367
Conversation
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
✅ Deploy Preview for hedera-hips ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
…bility with soloution Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than minor comments. LGTM
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very readable HIP even with the fine-grained detail, which is hard to accomplish! 🥂
To preserve its readability for future audiences, I would suggest removing details specific to the current codebase (e.g. code snippets).
Non-developers do not benefit from this level of detail; and any future who did need implementation details for some reason would be already be doing extensive archeology in the GitHub repo. 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
ac3dd6d
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
Description:
Related issue(s):
HIP for removing the token association limit.
Notes for reviewer:
Checklist