Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HIP-367 : Remove Token Association Limit #367

Merged
merged 10 commits into from
Apr 4, 2022
Merged

Conversation

anighanta
Copy link
Contributor

@anighanta anighanta commented Feb 18, 2022

Description:

Related issue(s):

HIP for removing the token association limit.

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
@netlify
Copy link

netlify bot commented Feb 18, 2022

Deploy Preview for hedera-hips ready!

Name Link
🔨 Latest commit acbcb4f
🔍 Latest deploy log https://app.netlify.com/sites/hedera-hips/deploys/624776c24174e50008832a75
😎 Deploy Preview https://deploy-preview-367--hedera-hips.netlify.app/hip/hip-367
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@anighanta anighanta marked this pull request as ready for review February 18, 2022 01:37
@anighanta anighanta marked this pull request as draft February 18, 2022 01:37
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
@anighanta anighanta requested a review from rbair23 March 2, 2022 05:58
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
HIP/hip-1000.md Outdated Show resolved Hide resolved
@anighanta anighanta changed the title initial draft for hip-1000 initial draft for hip-367 Mar 4, 2022
…bility with soloution

Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
HIP/hip-367.md Outdated Show resolved Hide resolved
HIP/hip-367.md Outdated Show resolved Hide resolved
HIP/hip-367.md Outdated Show resolved Hide resolved
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
@anighanta anighanta changed the title initial draft for hip-367 HIP-367 Mar 10, 2022
@anighanta anighanta changed the title HIP-367 HIP-367 : Remove Token association limit Mar 10, 2022
@anighanta anighanta changed the title HIP-367 : Remove Token association limit HIP-367 : Remove Token Association Limit Mar 10, 2022
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
@anighanta anighanta marked this pull request as ready for review March 11, 2022 16:05
Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than minor comments. LGTM

HIP/hip-367.md Outdated Show resolved Hide resolved
HIP/hip-367.md Outdated Show resolved Hide resolved
HIP/hip-367.md Outdated Show resolved Hide resolved
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
HIP/hip-367.md Outdated Show resolved Hide resolved
HIP/hip-367.md Outdated Show resolved Hide resolved
HIP/hip-367.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very readable HIP even with the fine-grained detail, which is hard to accomplish! 🥂

To preserve its readability for future audiences, I would suggest removing details specific to the current codebase (e.g. code snippets).

Non-developers do not benefit from this level of detail; and any future who did need implementation details for some reason would be already be doing extensive archeology in the GitHub repo. 😁

address review comments and remove code snippets

Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
Copy link
Contributor

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

SimiHunjan
SimiHunjan previously approved these changes Mar 30, 2022
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
Signed-off-by: anighanta <anirudh.ghanta@hedera.com>
HIP/hip-367.md Outdated Show resolved Hide resolved
HIP/hip-367.md Outdated Show resolved Hide resolved
HIP/hip-367.md Outdated Show resolved Hide resolved
HIP/hip-367.md Outdated Show resolved Hide resolved
@rbair23 rbair23 merged commit 6eed05c into hashgraph:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants