Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: flatten event impl #14592

Merged
merged 3 commits into from
Aug 6, 2024
Merged

chore: flatten event impl #14592

merged 3 commits into from
Aug 6, 2024

Conversation

lpetrovic05
Copy link
Member

closes #14555

@lpetrovic05
initial refactor done
123b228 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
remove comparable
1fdec68 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05
spot
de3be92 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
@lpetrovic05 lpetrovic05 added this to the v0.54 milestone Aug 5, 2024
@lpetrovic05 lpetrovic05 self-assigned this Aug 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Node: HAPI Test (Node Death Reconnect) Results

3 tests   3 ✅  5m 2s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit de3be92.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Node: HAPI Test (Token) Results

 22 files   22 suites   7m 5s ⏱️
281 tests 281 ✅ 0 💤 0 ❌
364 runs  364 ✅ 0 💤 0 ❌

Results for commit de3be92.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Node: HAPI Test (Restart) Results

7 files  7 suites   8m 12s ⏱️
6 tests 6 ✅ 0 💤 0 ❌
7 runs  7 ✅ 0 💤 0 ❌

Results for commit de3be92.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Node: HAPI Test (Crypto) Results

 24 files   24 suites   10m 32s ⏱️
347 tests 347 ✅ 0 💤 0 ❌
372 runs  372 ✅ 0 💤 0 ❌

Results for commit de3be92.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Node: HAPI Test (Misc) Results

 61 files   61 suites   16m 32s ⏱️
318 tests 318 ✅ 0 💤 0 ❌
408 runs  408 ✅ 0 💤 0 ❌

Results for commit de3be92.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Node: HAPI Test (Time Consuming) Results

19 tests   19 ✅  22m 38s ⏱️
 4 suites   0 💤
 4 files     0 ❌

Results for commit de3be92.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Node: HAPI Test (Smart Contract) Results

 90 files   90 suites   25m 12s ⏱️
658 tests 658 ✅ 0 💤 0 ❌
835 runs  835 ✅ 0 💤 0 ❌

Results for commit de3be92.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Node: Unit Test Results

  1 545 files    1 545 suites   3h 36m 48s ⏱️
117 440 tests 117 381 ✅ 59 💤 0 ❌
125 654 runs  125 595 ✅ 59 💤 0 ❌

Results for commit de3be92.

@lpetrovic05 lpetrovic05 marked this pull request as ready for review August 5, 2024 12:21
@lpetrovic05 lpetrovic05 requested review from a team as code owners August 5, 2024 12:21
@lpetrovic05 lpetrovic05 merged commit 16eb511 into develop Aug 6, 2024
66 of 67 checks passed
@lpetrovic05 lpetrovic05 deleted the 14555-D-flatten-and-rename-EventImpl branch August 6, 2024 10:09
HarshSawarkar pushed a commit to HarshSawarkar/hedera-services that referenced this pull request Aug 23, 2024
@lpetrovic05 @HarshSawarkar
chore: flatten event impl (hashgraph#14592)
bce99bf 
Signed-off-by: Lazar Petrovic <lpetrovic05@gmail.com>
Signed-off-by: Harsh Sawarkar <harshsawarkar111@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hendrikebbers hendrikebbers hendrikebbers approved these changes

@litt3 litt3 litt3 approved these changes

@kfa-aguda kfa-aguda Awaiting requested review from kfa-aguda kfa-aguda is a code owner automatically assigned from hashgraph/platform-hashgraph

@timo0 timo0 Awaiting requested review from timo0 timo0 is a code owner automatically assigned from hashgraph/platform-base

Assignees

@lpetrovic05 lpetrovic05

Labels
None yet
Projects
None yet
Milestone
v0.54
Development

Successfully merging this pull request may close these issues.

Flatten EventImpl
3 participants
@lpetrovic05 @hendrikebbers @litt3