Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Configuration support for GRPC messages #15472

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

thomas-swirlds-labs
Copy link
Contributor

Description:

  • Makes gRPC MaxMessageSize configurable
  • Makes gRPC MaxResponseSize configurable
  • Makes gRPC NoopMarshallerMaxMessageSize configurable
  • Adds Test Coverage for all fields in GrpcConfig

Related issue(s):

Fixes #4294

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
Signed-off-by: Thomas Moran <152873392+thomas-swirlds-labs@users.noreply.github.com>
@thomas-swirlds-labs thomas-swirlds-labs changed the title Add Configuration support for GRPC messages chore: Add Configuration support for GRPC messages Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.26%. Comparing base (aaff32c) to head (abaab50).

Files with missing lines Patch % Lines
...n/java/com/hedera/node/config/data/GrpcConfig.java 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15472   +/-   ##
==========================================
  Coverage      58.25%   58.26%           
- Complexity     21613    21620    +7     
==========================================
  Files           2781     2781           
  Lines         109289   109303   +14     
  Branches       11181    11179    -2     
==========================================
+ Hits           63668    63685   +17     
+ Misses         41754    41752    -2     
+ Partials        3867     3866    -1     
Files with missing lines Coverage Δ
...n/java/com/hedera/node/config/data/GrpcConfig.java 95.00% <93.75%> (+61.66%) ⬆️

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aaff32c) 109106 67425 61.80%
Head commit (abaab50) 109120 (+14) 67441 (+16) 61.80% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15472) 16 16 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add configuration support to hedera-app
1 participant