Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement gRPC publishBlockStream streaming of blocks #15541

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

petreze
Copy link
Contributor

@petreze petreze commented Sep 18, 2024

Description:

Related issue(s):

Fixes #15526, #15540

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
@petreze petreze added the Block Streams All Issues related to block streams label Sep 18, 2024
@petreze petreze added this to the v0.55 milestone Sep 18, 2024
@petreze petreze self-assigned this Sep 18, 2024
@petreze petreze linked an issue Sep 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 65.30612% with 17 lines in your changes missing coverage. Please review.

Project coverage is 58.21%. Comparing base (8dfd416) to head (96668f3).

Files with missing lines Patch % Lines
...dera/node/app/blocks/impl/GrpcBlockItemWriter.java 68.08% 15 Missing ⚠️
.../com/hedera/node/app/blocks/BlockStreamModule.java 0.00% 1 Missing ⚠️
.../node/app/blocks/config/BlockStreamGrpcConfig.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15541   +/-   ##
==========================================
  Coverage      58.21%   58.21%           
- Complexity     21617    21630   +13     
==========================================
  Files           2785     2787    +2     
  Lines         109530   109577   +47     
  Branches       11210    11214    +4     
==========================================
+ Hits           63764    63795   +31     
- Misses         41890    41911   +21     
+ Partials        3876     3871    -5     
Files with missing lines Coverage Δ
...a/node/app/blocks/impl/BlockStreamManagerImpl.java 97.97% <ø> (-0.02%) ⬇️
...com/hedera/node/config/data/BlockStreamConfig.java 33.33% <ø> (ø)
.../com/hedera/node/app/blocks/BlockStreamModule.java 0.00% <0.00%> (ø)
.../node/app/blocks/config/BlockStreamGrpcConfig.java 0.00% <0.00%> (ø)
...dera/node/app/blocks/impl/GrpcBlockItemWriter.java 68.08% <68.08%> (ø)

... and 24 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Sep 18, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 65.31%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8dfd416) 109347 67530 61.76%
Head commit (96668f3) 109394 (+47) 67556 (+26) 61.75% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15541) 49 32 65.31%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@petreze petreze marked this pull request as ready for review September 19, 2024 08:13
@petreze petreze requested review from a team as code owners September 19, 2024 08:13
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Signed-off-by: Petar Tonev <petar.tonev@limechain.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Streams All Issues related to block streams
Projects
None yet
1 participant