-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add file 101 update during the first transaction after a freeze upgrade #15563
Conversation
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15563 +/- ##
==========================================
Coverage 58.21% 58.21%
- Complexity 21611 21617 +6
==========================================
Files 2785 2785
Lines 109493 109530 +37
Branches 11200 11210 +10
==========================================
+ Hits 63738 63764 +26
- Misses 41889 41890 +1
- Partials 3866 3876 +10
|
Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think SysFileExportsTest
needs to have some more expectations added to cover this exactly, but the consensus side change LGTM, ty @iwsimon !
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, ty @iwsimon !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @iwsimon
Description:
Related issue(s):
Fixes #15557
Notes for reviewer:
Checklist