Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add file 101 update during the first transaction after a freeze upgrade #15563

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

iwsimon
Copy link
Contributor

@iwsimon iwsimon commented Sep 19, 2024

Description:

Related issue(s):

Fixes #15557

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
@iwsimon iwsimon added this to the v0.55 milestone Sep 19, 2024
@iwsimon iwsimon self-assigned this Sep 19, 2024
@iwsimon iwsimon requested review from a team as code owners September 19, 2024 17:08
Copy link

codacy-production bot commented Sep 19, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 3.57%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (193821e) 109310 67494 61.75%
Head commit (97c4bf8) 109347 (+37) 67530 (+36) 61.76% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15563) 28 1 3.57%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 3.57143% with 27 lines in your changes missing coverage. Please review.

Project coverage is 58.21%. Comparing base (193821e) to head (97c4bf8).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...app/service/file/impl/schemas/V0490FileSchema.java 0.00% 25 Missing ⚠️
...edera/node/app/workflows/handle/steps/UserTxn.java 0.00% 1 Missing ⚠️
...ra/node/app/service/file/impl/FileServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15563   +/-   ##
==========================================
  Coverage      58.21%   58.21%           
- Complexity     21611    21617    +6     
==========================================
  Files           2785     2785           
  Lines         109493   109530   +37     
  Branches       11200    11210   +10     
==========================================
+ Hits           63738    63764   +26     
- Misses         41889    41890    +1     
- Partials        3866     3876   +10     
Files with missing lines Coverage Δ
.../node/app/workflows/handle/record/SystemSetup.java 83.78% <100.00%> (ø)
...edera/node/app/workflows/handle/steps/UserTxn.java 0.00% <0.00%> (ø)
...ra/node/app/service/file/impl/FileServiceImpl.java 37.50% <0.00%> (ø)
...app/service/file/impl/schemas/V0490FileSchema.java 49.73% <0.00%> (-1.77%) ⬇️

... and 24 files with indirect coverage changes

Impacted file tree graph

Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
@iwsimon iwsimon requested a review from a team as a code owner September 19, 2024 21:27
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think SysFileExportsTest needs to have some more expectations added to cover this exactly, but the consensus side change LGTM, ty @iwsimon !

Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Copy link
Collaborator

@tinker-michaelj tinker-michaelj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty @iwsimon !

Copy link
Member

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @iwsimon

@iwsimon iwsimon merged commit ab7d11a into develop Sep 20, 2024
44 of 46 checks passed
@iwsimon iwsimon deleted the 15557-file101-update branch September 20, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add file 101 update during the first transaction after a freeze upgrade
3 participants