Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: hip-991 protobuf documentation fix #15567

Open
wants to merge 1 commit into
base: hip-991-topic-fees
Choose a base branch
from

Conversation

kimbor
Copy link
Member

@kimbor kimbor commented Sep 19, 2024

Update the protobuf docs for consensus_update_topic.proto to clarify the following:
-Only the admin key has to sign if the custom fee key is updated.

Related issue(s):
Fixes #15566

Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
@kimbor kimbor marked this pull request as ready for review September 19, 2024 21:19
@kimbor kimbor requested review from a team as code owners September 19, 2024 21:19
@kimbor kimbor self-assigned this Sep 19, 2024
@kimbor kimbor added this to the v0.55 milestone Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (hip-991-topic-fees@3b741ac). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##             hip-991-topic-fees   #15567   +/-   ##
=====================================================
  Coverage                      ?   58.06%           
  Complexity                    ?    21532           
=====================================================
  Files                         ?     2775           
  Lines                         ?   109025           
  Branches                      ?    11174           
=====================================================
  Hits                          ?    63308           
  Misses                        ?    41857           
  Partials                      ?     3860           

Impacted file tree graph

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 3b741ac1
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3b741ac) Report Missing Report Missing Report Missing
Head commit (2a4cc86) 108842 67058 61.61%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15567) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@kimbor kimbor linked an issue Sep 20, 2024 that may be closed by this pull request
@kimbor kimbor modified the milestone: v0.55 Sep 20, 2024
Copy link
Contributor

@netopyr netopyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks @kimbor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

topic fee update requirements change
2 participants