-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: hip-991 protobuf documentation fix #15567
base: hip-991-topic-fees
Are you sure you want to change the base?
Conversation
Signed-off-by: Kim Rader <kim.rader@swirldslabs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hip-991-topic-fees #15567 +/- ##
=====================================================
Coverage ? 58.06%
Complexity ? 21532
=====================================================
Files ? 2775
Lines ? 109025
Branches ? 11174
=====================================================
Hits ? 63308
Misses ? 41857
Partials ? 3860 |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks @kimbor
Update the protobuf docs for consensus_update_topic.proto to clarify the following:
-Only the admin key has to sign if the custom fee key is updated.
Related issue(s):
Fixes #15566