Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cover HIP-869 test plan #15568

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

tinker-michaelj
Copy link
Collaborator

@tinker-michaelj tinker-michaelj commented Sep 20, 2024

Description:

  • Closes Ensure DabFreezeTest has desired net-new coverage #15560 by extending DabEnabledUpgradeTest to include a "multipart" DAB edit that both deletes and updates new and existing nodes before and after PREPARE_UPGRADE; and validates that only the edits before the PREPARE_UPGRADE take effect.
  • Fixes a copy+paste error that could make DabEnabledUpgradeTest flake by creating a directory(!) at a config.txt path. 😳
  • For maximum safety, always resets the BlockStreamService singleton's migrated state hash before initializing schemas.
  • Adds a bit more detail to the BlockStreamManagerImpl initialization log.
  • ⚠️ Fixes an unreliable object referential equality check with Bytes.EMPTY in ConcurrentStreamingTreeHasher.
  • Adds RoundHeader block items.

iwsimon and others added 10 commits September 18, 2024 11:52
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Iris Simon <iris.simon@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
@tinker-michaelj tinker-michaelj added this to the v0.55 milestone Sep 20, 2024
@tinker-michaelj tinker-michaelj self-assigned this Sep 20, 2024
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 35.29412% with 11 lines in your changes missing coverage. Please review.

Project coverage is 58.21%. Comparing base (aa75ff7) to head (5f273b0).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...-app/src/main/java/com/hedera/node/app/Hedera.java 0.00% 4 Missing ⚠️
...com/hedera/node/app/blocks/BlockStreamService.java 25.00% 3 Missing ⚠️
...dera/node/app/workflows/handle/HandleWorkflow.java 0.00% 3 Missing ⚠️
...a/node/app/blocks/impl/BlockStreamManagerImpl.java 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             develop   #15568   +/-   ##
==========================================
  Coverage      58.20%   58.21%           
- Complexity     21604    21617   +13     
==========================================
  Files           2785     2785           
  Lines         109481   109542   +61     
  Branches       11200    11211   +11     
==========================================
+ Hits           63721    63767   +46     
- Misses         41887    41898   +11     
- Partials        3873     3877    +4     
Files with missing lines Coverage Δ
...app/blocks/impl/ConcurrentStreamingTreeHasher.java 95.09% <100.00%> (ø)
...a/node/app/blocks/impl/BlockStreamManagerImpl.java 97.52% <80.00%> (-0.47%) ⬇️
...com/hedera/node/app/blocks/BlockStreamService.java 68.75% <25.00%> (-14.59%) ⬇️
...dera/node/app/workflows/handle/HandleWorkflow.java 27.58% <0.00%> (-0.42%) ⬇️
...-app/src/main/java/com/hedera/node/app/Hedera.java 11.67% <0.00%> (-0.08%) ⬇️

... and 17 files with indirect coverage changes

Impacted file tree graph

Copy link

codacy-production bot commented Sep 20, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 41.18%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (aa75ff7) 109298 67484 61.74%
Head commit (5f273b0) 109359 (+61) 67534 (+50) 61.75% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#15568) 17 7 41.18%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ensure DabFreezeTest has desired net-new coverage
2 participants