Remove all FCOneToManyRelation use and update EETs to only verify NOT…
#2962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 10, 2022 11:45
…_SUPPORTED Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
Codecov Report
@@ Coverage Diff @@
## master #2962 +/- ##
============================================
- Coverage 96.16% 96.13% -0.04%
+ Complexity 10523 10310 -213
============================================
Files 731 718 -13
Lines 29217 28668 -549
Branches 3089 3029 -60
============================================
- Hits 28096 27559 -537
Misses 530 530
+ Partials 591 579 -12
Continue to review full report at Codecov.
|
Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
…enId class Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
anighanta
pushed a commit
that referenced
this pull request
Mar 15, 2022
) * Use June 10, 2022 system entity expiry to simplify DevOps workflows Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove gRPC intermediary from `EvmFnResult` construction (#2954) * Initial commit with EvmFnResultBench Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Disable CI for now Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Re-enable CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Avoid gRPC intermediary in creating ExpirableTxnRecord w/ call result Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Include benchmarks directory in build image Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove duplicate code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Uncomment EETs Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix approve/allowance issue with INFINITE supply type fungible tokens (#2956) * Fix approve/allowance issue with INFINITE supply type fungible tokens Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Fix unit tests for approve/adjust allowance checks Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Remove all `FCOneToManyRelation` use and update EETs to only verify NOT… (#2962) * Remove all FCOneToManyRelation use and update EETs to only verify NOT_SUPPORTED Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unused tokens.nfts.areQueriesEnabled property, MerkleUniqueTokenId class Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Bump crypto from 22.1.0 to 22.1.1 (#2930) * Bump log4j.version from 2.17.1 to 2.17.2 (#2931) * Update maven version in Dockerfile - 3.8.4 is missing from https://dlcdn.apache.org/maven/maven-3/ (#2975) Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Back `AliasManager` with `FCHashMap` from `StateMetadata` (#2969) * Remove unnecessary StateAccessor wrapper Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Add the aliases FCHashMap<ByteString, EntityNum> to state metadata and MutableStateChildren Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Switch to FCHashMap in AliasManager Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use separate AliasManager in StateChildrenSigMetadataLookup Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Eliminate unnecessary use of TokenStore in StateView Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use different maven download link Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit tests Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Address reviewer comments Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix StateModule.provideWorkingAliases() signature Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use receiver (not sender address) to infer expiry of just-created contract (#2967) * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Disable CI for now Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Reenable CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Uncomment suites Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix javadoc, code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove the intermediary TransferList for converting to CurrencyAdjustments (#2966) * initial commit Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix a few tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix a few tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix sonar smells Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * add benchmark Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * add benchmark Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * use static constant Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * update benchmark to have purging adjustments Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * update changes array size to 10 Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * change to modify in place Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * Use different maven download link Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * address review comments Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * reset tracker every invocation Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix sonar smells Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * remove `numHbarBalancesChangedSoFar` pased to `CurrencyAdjustments` Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * ALWAYS copy the arrays passed into `CurrencyAdjustments` to avoid problems Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> Co-authored-by: tinker-michaelj <michael.tinker@hedera.com> * Add fee to record, expiry to new account in `AutoCreationLogic` (#2979) * Add fee to record, expiry to new account in AutoCreationLogic Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Stabilize CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix all but one unit test 😓 Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix all unit tests, remove dead code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Neeha <52669918+Neeharika-Sompalli@users.noreply.github.com>
anighanta
added a commit
that referenced
this pull request
Mar 16, 2022
* initial commit Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * port away from MerkleAccountTokens Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * feature complete.. need unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix HTSPrecompiledContract with the right assocationLogic Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * eet for demo Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove assocaition limit on token per account and getAccountInfo query should only return the next 1000 assocaitions Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * comment out irrelevant specs Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * handle empty ids array Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove irrelevant unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * only persist the tokenIdsIndex on the acutal getInfo query Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add a limit of 1 token association to prove the limit doenst mean a thing anymore Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * make account getInfo query only return the first n token association in the getInfo query on an account/contract where n is dynamic prop Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove dead code Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add even more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove irrelevant eet specs Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add back the deleted MerkleAccountTokens for backward compatibility until the next release Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * update the MerkleAccount back to having tokens but dont use them anywhere and during migrations update the links in MapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit test for migration of MerkleAccountTokens to mapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fixed the euqality check for migrating MerkleAccountTokens to mapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add asserts to getInfo for validating we only give out tokenAssocaitions limited by the setting tokens.maxPerAccount Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove commented out irrelavent tests and fix dissocaition workflow to use tokenRelations from a instaed of loading it again Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address review comments Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * resolve code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * initial commit Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * skip vlaidating zero token balances on account delete transaction Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add missing imports Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * use MerkleAccount getter instead of MerkleAccountState ones Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * update zeroBalance token assocaitions count on burn, mint and wipe actions as well Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * added unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix failing unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * added back the token balance check on crypotDelete transaction Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit test coverage on servicesState Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * only decrement numZeroBalance when dissociating if the association balance is zero Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * move updating the association and zeroBalance counter to before updating relationships for dissociation Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix comparing alias address Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address review comments Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * Resolve merge conflicts, maximize reuse of `doBoundedIteration()` (#2984) * Use June 10, 2022 system entity expiry to simplify DevOps workflows Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove gRPC intermediary from `EvmFnResult` construction (#2954) * Initial commit with EvmFnResultBench Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Disable CI for now Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Re-enable CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Avoid gRPC intermediary in creating ExpirableTxnRecord w/ call result Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Include benchmarks directory in build image Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove duplicate code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Uncomment EETs Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix approve/allowance issue with INFINITE supply type fungible tokens (#2956) * Fix approve/allowance issue with INFINITE supply type fungible tokens Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Fix unit tests for approve/adjust allowance checks Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Remove all `FCOneToManyRelation` use and update EETs to only verify NOT… (#2962) * Remove all FCOneToManyRelation use and update EETs to only verify NOT_SUPPORTED Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unused tokens.nfts.areQueriesEnabled property, MerkleUniqueTokenId class Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Bump crypto from 22.1.0 to 22.1.1 (#2930) * Bump log4j.version from 2.17.1 to 2.17.2 (#2931) * Update maven version in Dockerfile - 3.8.4 is missing from https://dlcdn.apache.org/maven/maven-3/ (#2975) Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Back `AliasManager` with `FCHashMap` from `StateMetadata` (#2969) * Remove unnecessary StateAccessor wrapper Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Add the aliases FCHashMap<ByteString, EntityNum> to state metadata and MutableStateChildren Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Switch to FCHashMap in AliasManager Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use separate AliasManager in StateChildrenSigMetadataLookup Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Eliminate unnecessary use of TokenStore in StateView Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use different maven download link Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit tests Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Address reviewer comments Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix StateModule.provideWorkingAliases() signature Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use receiver (not sender address) to infer expiry of just-created contract (#2967) * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Disable CI for now Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Reenable CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Uncomment suites Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix javadoc, code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove the intermediary TransferList for converting to CurrencyAdjustments (#2966) * initial commit Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix a few tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix a few tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix sonar smells Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * add benchmark Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * add benchmark Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * use static constant Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * update benchmark to have purging adjustments Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * update changes array size to 10 Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * change to modify in place Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * Use different maven download link Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * address review comments Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * reset tracker every invocation Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix sonar smells Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * remove `numHbarBalancesChangedSoFar` pased to `CurrencyAdjustments` Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * ALWAYS copy the arrays passed into `CurrencyAdjustments` to avoid problems Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> Co-authored-by: tinker-michaelj <michael.tinker@hedera.com> * Add fee to record, expiry to new account in `AutoCreationLogic` (#2979) * Add fee to record, expiry to new account in AutoCreationLogic Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Stabilize CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix all but one unit test 😓 Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix all unit tests, remove dead code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Neeha <52669918+Neeharika-Sompalli@users.noreply.github.com> * Add javadoc and unit tests Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unnecessary object creation in doBoundedIteration Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Be more idiomatic Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove dead code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> Co-authored-by: Michael Tinker <michael.tinker@hedera.com> Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Neeha <52669918+Neeharika-Sompalli@users.noreply.github.com>
rjuang
pushed a commit
that referenced
this pull request
Mar 23, 2022
…OT… (#2962) * Remove all FCOneToManyRelation use and update EETs to only verify NOT_SUPPORTED Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unused tokens.nfts.areQueriesEnabled property, MerkleUniqueTokenId class Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> Signed-off-by: Ray Juang <radford.juang@hedera.com>
rjuang
pushed a commit
that referenced
this pull request
Mar 23, 2022
* initial commit Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * port away from MerkleAccountTokens Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * feature complete.. need unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix HTSPrecompiledContract with the right assocationLogic Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * eet for demo Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove assocaition limit on token per account and getAccountInfo query should only return the next 1000 assocaitions Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * comment out irrelevant specs Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * handle empty ids array Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove irrelevant unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * only persist the tokenIdsIndex on the acutal getInfo query Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add a limit of 1 token association to prove the limit doenst mean a thing anymore Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * make account getInfo query only return the first n token association in the getInfo query on an account/contract where n is dynamic prop Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove dead code Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add even more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove irrelevant eet specs Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add back the deleted MerkleAccountTokens for backward compatibility until the next release Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * update the MerkleAccount back to having tokens but dont use them anywhere and during migrations update the links in MapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit test for migration of MerkleAccountTokens to mapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fixed the euqality check for migrating MerkleAccountTokens to mapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add asserts to getInfo for validating we only give out tokenAssocaitions limited by the setting tokens.maxPerAccount Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove commented out irrelavent tests and fix dissocaition workflow to use tokenRelations from a instaed of loading it again Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address review comments Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * resolve code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * initial commit Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * skip vlaidating zero token balances on account delete transaction Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add missing imports Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * use MerkleAccount getter instead of MerkleAccountState ones Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * update zeroBalance token assocaitions count on burn, mint and wipe actions as well Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * added unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix failing unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * added back the token balance check on crypotDelete transaction Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit test coverage on servicesState Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * only decrement numZeroBalance when dissociating if the association balance is zero Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * move updating the association and zeroBalance counter to before updating relationships for dissociation Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix comparing alias address Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address review comments Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * Resolve merge conflicts, maximize reuse of `doBoundedIteration()` (#2984) * Use June 10, 2022 system entity expiry to simplify DevOps workflows Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove gRPC intermediary from `EvmFnResult` construction (#2954) * Initial commit with EvmFnResultBench Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Disable CI for now Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Re-enable CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Avoid gRPC intermediary in creating ExpirableTxnRecord w/ call result Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Include benchmarks directory in build image Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove duplicate code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Uncomment EETs Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix approve/allowance issue with INFINITE supply type fungible tokens (#2956) * Fix approve/allowance issue with INFINITE supply type fungible tokens Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Fix unit tests for approve/adjust allowance checks Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Remove all `FCOneToManyRelation` use and update EETs to only verify NOT… (#2962) * Remove all FCOneToManyRelation use and update EETs to only verify NOT_SUPPORTED Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unused tokens.nfts.areQueriesEnabled property, MerkleUniqueTokenId class Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Bump crypto from 22.1.0 to 22.1.1 (#2930) * Bump log4j.version from 2.17.1 to 2.17.2 (#2931) * Update maven version in Dockerfile - 3.8.4 is missing from https://dlcdn.apache.org/maven/maven-3/ (#2975) Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Back `AliasManager` with `FCHashMap` from `StateMetadata` (#2969) * Remove unnecessary StateAccessor wrapper Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Add the aliases FCHashMap<ByteString, EntityNum> to state metadata and MutableStateChildren Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Switch to FCHashMap in AliasManager Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use separate AliasManager in StateChildrenSigMetadataLookup Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Eliminate unnecessary use of TokenStore in StateView Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use different maven download link Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit tests Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Address reviewer comments Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix StateModule.provideWorkingAliases() signature Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use receiver (not sender address) to infer expiry of just-created contract (#2967) * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Disable CI for now Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Reenable CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Uncomment suites Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix javadoc, code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove the intermediary TransferList for converting to CurrencyAdjustments (#2966) * initial commit Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix a few tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix a few tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix sonar smells Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * add benchmark Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * add benchmark Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * use static constant Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * update benchmark to have purging adjustments Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * update changes array size to 10 Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * change to modify in place Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * Use different maven download link Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * address review comments Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * reset tracker every invocation Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix sonar smells Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * remove `numHbarBalancesChangedSoFar` pased to `CurrencyAdjustments` Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * ALWAYS copy the arrays passed into `CurrencyAdjustments` to avoid problems Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> Co-authored-by: tinker-michaelj <michael.tinker@hedera.com> * Add fee to record, expiry to new account in `AutoCreationLogic` (#2979) * Add fee to record, expiry to new account in AutoCreationLogic Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Stabilize CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix all but one unit test 😓 Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix all unit tests, remove dead code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Neeha <52669918+Neeharika-Sompalli@users.noreply.github.com> * Add javadoc and unit tests Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unnecessary object creation in doBoundedIteration Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Be more idiomatic Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove dead code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> Co-authored-by: Michael Tinker <michael.tinker@hedera.com> Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Neeha <52669918+Neeharika-Sompalli@users.noreply.github.com>
rjuang
pushed a commit
that referenced
this pull request
Mar 23, 2022
…OT… (#2962) * Remove all FCOneToManyRelation use and update EETs to only verify NOT_SUPPORTED Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unused tokens.nfts.areQueriesEnabled property, MerkleUniqueTokenId class Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> Signed-off-by: Ray Juang <radford.juang@hedera.com>
rjuang
pushed a commit
that referenced
this pull request
Mar 23, 2022
* initial commit Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * port away from MerkleAccountTokens Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * feature complete.. need unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix HTSPrecompiledContract with the right assocationLogic Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * eet for demo Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove assocaition limit on token per account and getAccountInfo query should only return the next 1000 assocaitions Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * comment out irrelevant specs Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * handle empty ids array Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove irrelevant unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * only persist the tokenIdsIndex on the acutal getInfo query Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add a limit of 1 token association to prove the limit doenst mean a thing anymore Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * make account getInfo query only return the first n token association in the getInfo query on an account/contract where n is dynamic prop Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove dead code Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add even more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove irrelevant eet specs Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add back the deleted MerkleAccountTokens for backward compatibility until the next release Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * update the MerkleAccount back to having tokens but dont use them anywhere and during migrations update the links in MapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit test for migration of MerkleAccountTokens to mapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fixed the euqality check for migrating MerkleAccountTokens to mapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add asserts to getInfo for validating we only give out tokenAssocaitions limited by the setting tokens.maxPerAccount Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove commented out irrelavent tests and fix dissocaition workflow to use tokenRelations from a instaed of loading it again Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address review comments Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * resolve code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * initial commit Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * skip vlaidating zero token balances on account delete transaction Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add missing imports Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * use MerkleAccount getter instead of MerkleAccountState ones Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * update zeroBalance token assocaitions count on burn, mint and wipe actions as well Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * added unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix failing unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * added back the token balance check on crypotDelete transaction Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit test coverage on servicesState Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * only decrement numZeroBalance when dissociating if the association balance is zero Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * move updating the association and zeroBalance counter to before updating relationships for dissociation Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix comparing alias address Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address review comments Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * Resolve merge conflicts, maximize reuse of `doBoundedIteration()` (#2984) * Use June 10, 2022 system entity expiry to simplify DevOps workflows Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove gRPC intermediary from `EvmFnResult` construction (#2954) * Initial commit with EvmFnResultBench Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Disable CI for now Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Re-enable CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Avoid gRPC intermediary in creating ExpirableTxnRecord w/ call result Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Include benchmarks directory in build image Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove duplicate code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Uncomment EETs Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix approve/allowance issue with INFINITE supply type fungible tokens (#2956) * Fix approve/allowance issue with INFINITE supply type fungible tokens Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Fix unit tests for approve/adjust allowance checks Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Remove all `FCOneToManyRelation` use and update EETs to only verify NOT… (#2962) * Remove all FCOneToManyRelation use and update EETs to only verify NOT_SUPPORTED Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unused tokens.nfts.areQueriesEnabled property, MerkleUniqueTokenId class Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Bump crypto from 22.1.0 to 22.1.1 (#2930) * Bump log4j.version from 2.17.1 to 2.17.2 (#2931) * Update maven version in Dockerfile - 3.8.4 is missing from https://dlcdn.apache.org/maven/maven-3/ (#2975) Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Back `AliasManager` with `FCHashMap` from `StateMetadata` (#2969) * Remove unnecessary StateAccessor wrapper Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Add the aliases FCHashMap<ByteString, EntityNum> to state metadata and MutableStateChildren Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Switch to FCHashMap in AliasManager Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use separate AliasManager in StateChildrenSigMetadataLookup Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Eliminate unnecessary use of TokenStore in StateView Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use different maven download link Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit tests Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Address reviewer comments Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix StateModule.provideWorkingAliases() signature Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use receiver (not sender address) to infer expiry of just-created contract (#2967) * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Disable CI for now Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Reenable CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Uncomment suites Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix javadoc, code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove the intermediary TransferList for converting to CurrencyAdjustments (#2966) * initial commit Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix a few tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix a few tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix sonar smells Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * add benchmark Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * add benchmark Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * use static constant Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * update benchmark to have purging adjustments Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * update changes array size to 10 Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * change to modify in place Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * Use different maven download link Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * address review comments Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * reset tracker every invocation Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix sonar smells Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * remove `numHbarBalancesChangedSoFar` pased to `CurrencyAdjustments` Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * ALWAYS copy the arrays passed into `CurrencyAdjustments` to avoid problems Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> Co-authored-by: tinker-michaelj <michael.tinker@hedera.com> * Add fee to record, expiry to new account in `AutoCreationLogic` (#2979) * Add fee to record, expiry to new account in AutoCreationLogic Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Stabilize CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix all but one unit test 😓 Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix all unit tests, remove dead code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Neeha <52669918+Neeharika-Sompalli@users.noreply.github.com> * Add javadoc and unit tests Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unnecessary object creation in doBoundedIteration Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Be more idiomatic Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove dead code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> Co-authored-by: Michael Tinker <michael.tinker@hedera.com> Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Neeha <52669918+Neeharika-Sompalli@users.noreply.github.com> Signed-off-by: Ray Juang <radford.juang@hedera.com>
rjuang
pushed a commit
that referenced
this pull request
Mar 23, 2022
…OT… (#2962) * Remove all FCOneToManyRelation use and update EETs to only verify NOT_SUPPORTED Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unused tokens.nfts.areQueriesEnabled property, MerkleUniqueTokenId class Signed-off-by: tinker-michaelj <michael.tinker@hedera.com>
rjuang
pushed a commit
that referenced
this pull request
Mar 23, 2022
* initial commit Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * port away from MerkleAccountTokens Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * feature complete.. need unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix HTSPrecompiledContract with the right assocationLogic Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * eet for demo Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove assocaition limit on token per account and getAccountInfo query should only return the next 1000 assocaitions Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * comment out irrelevant specs Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * handle empty ids array Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove irrelevant unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * only persist the tokenIdsIndex on the acutal getInfo query Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add a limit of 1 token association to prove the limit doenst mean a thing anymore Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * make account getInfo query only return the first n token association in the getInfo query on an account/contract where n is dynamic prop Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove dead code Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add even more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove irrelevant eet specs Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add back the deleted MerkleAccountTokens for backward compatibility until the next release Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * update the MerkleAccount back to having tokens but dont use them anywhere and during migrations update the links in MapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit test for migration of MerkleAccountTokens to mapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fixed the euqality check for migrating MerkleAccountTokens to mapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add asserts to getInfo for validating we only give out tokenAssocaitions limited by the setting tokens.maxPerAccount Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove commented out irrelavent tests and fix dissocaition workflow to use tokenRelations from a instaed of loading it again Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address review comments Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * resolve code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * initial commit Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * skip vlaidating zero token balances on account delete transaction Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add missing imports Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * use MerkleAccount getter instead of MerkleAccountState ones Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * update zeroBalance token assocaitions count on burn, mint and wipe actions as well Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * added unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix failing unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * added back the token balance check on crypotDelete transaction Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit test coverage on servicesState Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * only decrement numZeroBalance when dissociating if the association balance is zero Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * move updating the association and zeroBalance counter to before updating relationships for dissociation Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix comparing alias address Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address review comments Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * Resolve merge conflicts, maximize reuse of `doBoundedIteration()` (#2984) * Use June 10, 2022 system entity expiry to simplify DevOps workflows Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove gRPC intermediary from `EvmFnResult` construction (#2954) * Initial commit with EvmFnResultBench Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Disable CI for now Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Re-enable CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Avoid gRPC intermediary in creating ExpirableTxnRecord w/ call result Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Include benchmarks directory in build image Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove duplicate code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Uncomment EETs Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix approve/allowance issue with INFINITE supply type fungible tokens (#2956) * Fix approve/allowance issue with INFINITE supply type fungible tokens Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Fix unit tests for approve/adjust allowance checks Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Remove all `FCOneToManyRelation` use and update EETs to only verify NOT… (#2962) * Remove all FCOneToManyRelation use and update EETs to only verify NOT_SUPPORTED Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unused tokens.nfts.areQueriesEnabled property, MerkleUniqueTokenId class Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Bump crypto from 22.1.0 to 22.1.1 (#2930) * Bump log4j.version from 2.17.1 to 2.17.2 (#2931) * Update maven version in Dockerfile - 3.8.4 is missing from https://dlcdn.apache.org/maven/maven-3/ (#2975) Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Back `AliasManager` with `FCHashMap` from `StateMetadata` (#2969) * Remove unnecessary StateAccessor wrapper Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Add the aliases FCHashMap<ByteString, EntityNum> to state metadata and MutableStateChildren Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Switch to FCHashMap in AliasManager Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use separate AliasManager in StateChildrenSigMetadataLookup Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Eliminate unnecessary use of TokenStore in StateView Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use different maven download link Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit tests Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Address reviewer comments Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix StateModule.provideWorkingAliases() signature Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use receiver (not sender address) to infer expiry of just-created contract (#2967) * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Disable CI for now Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Reenable CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Uncomment suites Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix javadoc, code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove the intermediary TransferList for converting to CurrencyAdjustments (#2966) * initial commit Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix a few tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix a few tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix sonar smells Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * add benchmark Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * add benchmark Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * use static constant Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * update benchmark to have purging adjustments Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * update changes array size to 10 Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * change to modify in place Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * Use different maven download link Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * address review comments Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * reset tracker every invocation Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix sonar smells Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * remove `numHbarBalancesChangedSoFar` pased to `CurrencyAdjustments` Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * ALWAYS copy the arrays passed into `CurrencyAdjustments` to avoid problems Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> Co-authored-by: tinker-michaelj <michael.tinker@hedera.com> * Add fee to record, expiry to new account in `AutoCreationLogic` (#2979) * Add fee to record, expiry to new account in AutoCreationLogic Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Stabilize CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix all but one unit test 😓 Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix all unit tests, remove dead code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Neeha <52669918+Neeharika-Sompalli@users.noreply.github.com> * Add javadoc and unit tests Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unnecessary object creation in doBoundedIteration Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Be more idiomatic Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove dead code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> Co-authored-by: Michael Tinker <michael.tinker@hedera.com> Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Neeha <52669918+Neeharika-Sompalli@users.noreply.github.com>
anighanta
added a commit
that referenced
this pull request
Mar 29, 2022
* initial commit Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * port away from MerkleAccountTokens Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * feature complete.. need unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix HTSPrecompiledContract with the right assocationLogic Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * eet for demo Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove assocaition limit on token per account and getAccountInfo query should only return the next 1000 assocaitions Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * comment out irrelevant specs Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * handle empty ids array Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove irrelevant unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * only persist the tokenIdsIndex on the acutal getInfo query Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add a limit of 1 token association to prove the limit doenst mean a thing anymore Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * make account getInfo query only return the first n token association in the getInfo query on an account/contract where n is dynamic prop Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove dead code Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add even more unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove irrelevant eet specs Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add back the deleted MerkleAccountTokens for backward compatibility until the next release Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * update the MerkleAccount back to having tokens but dont use them anywhere and during migrations update the links in MapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit test for migration of MerkleAccountTokens to mapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fixed the euqality check for migrating MerkleAccountTokens to mapValuedLinkedList Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add asserts to getInfo for validating we only give out tokenAssocaitions limited by the setting tokens.maxPerAccount Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * remove commented out irrelavent tests and fix dissocaition workflow to use tokenRelations from a instaed of loading it again Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address review comments Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * resolve code smells Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * initial commit Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * skip vlaidating zero token balances on account delete transaction Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add missing imports Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * use MerkleAccount getter instead of MerkleAccountState ones Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * update zeroBalance token assocaitions count on burn, mint and wipe actions as well Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * added unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix failing unit tests Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * added back the token balance check on crypotDelete transaction Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * add unit test coverage on servicesState Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * only decrement numZeroBalance when dissociating if the association balance is zero Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * move updating the association and zeroBalance counter to before updating relationships for dissociation Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix comparing alias address Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * address review comments Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * Resolve merge conflicts, maximize reuse of `doBoundedIteration()` (#2984) * Use June 10, 2022 system entity expiry to simplify DevOps workflows Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove gRPC intermediary from `EvmFnResult` construction (#2954) * Initial commit with EvmFnResultBench Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Disable CI for now Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Re-enable CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Avoid gRPC intermediary in creating ExpirableTxnRecord w/ call result Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Include benchmarks directory in build image Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove duplicate code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Uncomment EETs Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix approve/allowance issue with INFINITE supply type fungible tokens (#2956) * Fix approve/allowance issue with INFINITE supply type fungible tokens Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Fix unit tests for approve/adjust allowance checks Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Remove all `FCOneToManyRelation` use and update EETs to only verify NOT… (#2962) * Remove all FCOneToManyRelation use and update EETs to only verify NOT_SUPPORTED Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unused tokens.nfts.areQueriesEnabled property, MerkleUniqueTokenId class Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Bump crypto from 22.1.0 to 22.1.1 (#2930) * Bump log4j.version from 2.17.1 to 2.17.2 (#2931) * Update maven version in Dockerfile - 3.8.4 is missing from https://dlcdn.apache.org/maven/maven-3/ (#2975) Signed-off-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> * Back `AliasManager` with `FCHashMap` from `StateMetadata` (#2969) * Remove unnecessary StateAccessor wrapper Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Add the aliases FCHashMap<ByteString, EntityNum> to state metadata and MutableStateChildren Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Switch to FCHashMap in AliasManager Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use separate AliasManager in StateChildrenSigMetadataLookup Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Eliminate unnecessary use of TokenStore in StateView Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use different maven download link Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit tests Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Address reviewer comments Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix StateModule.provideWorkingAliases() signature Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Use receiver (not sender address) to infer expiry of just-created contract (#2967) * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Disable CI for now Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Reenable CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Uncomment suites Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix javadoc, code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove the intermediary TransferList for converting to CurrencyAdjustments (#2966) * initial commit Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix a few tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix a few tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix sonar smells Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * add benchmark Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * add benchmark Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * use static constant Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * update benchmark to have purging adjustments Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * update changes array size to 10 Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * change to modify in place Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix tests Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * Use different maven download link Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * address review comments Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * reset tracker every invocation Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * fix sonar smells Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * remove `numHbarBalancesChangedSoFar` pased to `CurrencyAdjustments` Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> * ALWAYS copy the arrays passed into `CurrencyAdjustments` to avoid problems Signed-off-by: Neeharika-Sompalli <neeharika.sompalli@hedera.com> Co-authored-by: tinker-michaelj <michael.tinker@hedera.com> * Add fee to record, expiry to new account in `AutoCreationLogic` (#2979) * Add fee to record, expiry to new account in AutoCreationLogic Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Stabilize CI Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix all but one unit test 😓 Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Intermezzo Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix unit test Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix all unit tests, remove dead code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Fix code smells Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Neeha <52669918+Neeharika-Sompalli@users.noreply.github.com> * Add javadoc and unit tests Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove unnecessary object creation in doBoundedIteration Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Be more idiomatic Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * Remove dead code Signed-off-by: tinker-michaelj <michael.tinker@hedera.com> * merge master Signed-off-by: anighanta <anirudh.ghanta@hedera.com> * fix unit test Signed-off-by: anighanta <anirudh.ghanta@hedera.com> Co-authored-by: Michael Tinker <michael.tinker@hedera.com> Co-authored-by: Stoyan Panayotov <stoyan.panayotov@limechain.tech> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Neeha <52669918+Neeharika-Sompalli@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
FCOneToManyRelations and collaborators from codebase and permanently disables the deprecatedgetAccountNftInfosandgetTokenNftInfosqueries.NOT_SUPPORTED.< moment of silence >