Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new AWS region, ap-southeast-5 (Malaysia) #1156

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

amirasyraf
Copy link
Contributor

@amirasyraf amirasyraf commented Aug 27, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #1151.

Add new ap-southeast-5 AWS Region

@amirasyraf amirasyraf requested a review from a team as a code owner August 27, 2024 05:14
Copy link

hashicorp-cla-app bot commented Aug 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@ewbankkit ewbankkit self-assigned this Aug 27, 2024
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@ewbankkit
Copy link
Contributor

@amirasyraf Thanks for the contribution 🎉 👏.

@ewbankkit ewbankkit merged commit de5560c into hashicorp:main Aug 27, 2024
12 checks passed
@amirasyraf amirasyraf deleted the feat/ap-southeast-5-endpoint branch August 28, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new ap-southeast-5 AWS Region to internal/endpoints/endpoints.go
2 participants