Uses AWS SDK BuildableClient for custom HTTP client #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YakDriver
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
Looks good! 🎉
% make test
go test -timeout=30s -parallel=4 ./...
go: downloading github.com/aws/aws-sdk-go-v2/config v1.13.1
go: downloading github.com/aws/aws-sdk-go-v2/internal/ini v1.3.5
ok github.com/hashicorp/aws-sdk-go-base/v2 1.574s
? github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/config [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/constants [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints [no test files]
ok github.com/hashicorp/aws-sdk-go-base/v2/internal/httpclient 0.587s
? github.com/hashicorp/aws-sdk-go-base/v2/mockdata [no test files]
? github.com/hashicorp/aws-sdk-go-base/v2/servicemocks [no test files]
cd v2/awsv1shim && go test -timeout=30s -parallel=4 ./...
go: downloading github.com/aws/aws-sdk-go v1.42.52
ok github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2 0.908s
? github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/mockdata [no test files]
ok github.com/hashicorp/aws-sdk-go-base/v2/awsv1shim/v2/tfawserr 0.822s| t.Fatalf("unexpected error: %s", err) | ||
| } | ||
|
|
||
| transport := client.GetTransport() |
There was a problem hiding this comment.
AWS is a Java shop :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom HTTP client previously used did not properly handle retrieving credentials from IMDS when running in a container. Replaced the client with the BuildableClient supplied by the AWS SDK.
Closes #110
Relates hashicorp/terraform-provider-aws#23110
Relates hashicorp/terraform-provider-aws#23182