Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds IAM role chaining #1170

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Adds IAM role chaining #1170

merged 4 commits into from
Sep 11, 2024

Conversation

gdavison
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Reference: hashicorp/terraform-provider-aws#22728

Adds support for IAM role chaining when assuming roles.

@gdavison gdavison requested a review from a team as a code owner September 10, 2024 17:24
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test ./...
?   	github.com/hashicorp/aws-sdk-go-base/v2/configtesting	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/awsconfig	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/constants	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/errs	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/slices	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/internal/test	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/mockdata	[no test files]
?   	github.com/hashicorp/aws-sdk-go-base/v2/servicemocks	[no test files]
ok  	github.com/hashicorp/aws-sdk-go-base/v2	13.959s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/diag	0.417s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/config	0.738s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/endpoints	0.993s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/internal/expand	0.560s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/logging	1.118s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/tfawserr	1.611s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/useragent	1.498s
ok  	github.com/hashicorp/aws-sdk-go-base/v2/validation	0.806s

Needs a CHANGELOG entry because of the breaking change to Config.AssumRole.

@gdavison gdavison merged commit 688693c into main Sep 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants