Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds logging for authentication flow #146

Merged
merged 4 commits into from
Feb 25, 2022
Merged

Adds logging for authentication flow #146

merged 4 commits into from
Feb 25, 2022

Conversation

gdavison
Copy link
Contributor

Adds logging for authentication flow. Also adds warning and additional error info when Profile and AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY env vars are set.

Closes #134
Closes #135

@gdavison gdavison requested a review from a team as a code owner February 24, 2022 23:44
ewbankkit
ewbankkit approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% go test .
ok  	github.com/hashicorp/aws-sdk-go-base/v2	1.893s

@gdavison gdavison merged commit 22cb4e5 into main Feb 25, 2022
@gdavison gdavison deleted the auth-logging branch February 25, 2022 18:17
gdavison added a commit that referenced this pull request Feb 25, 2022
@gdavison
Updates CHANGELOG for #146
5eff8a8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gdavison @ewbankkit