Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't override shared files unless they're set #151

Merged
merged 1 commit into from
Feb 28, 2022
Merged

Don't override shared files unless they're set #151

merged 1 commit into from
Feb 28, 2022

Conversation

gdavison
Copy link
Contributor

In profile validation, only override shared config and credentials files if they're set

@gdavison gdavison requested a review from a team as a code owner February 28, 2022 19:48
ewbankkit
ewbankkit approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@gdavison gdavison merged commit 27fc24f into main Feb 28, 2022
@gdavison gdavison deleted the fix_default_shared_files branch February 28, 2022 20:24
gdavison added a commit that referenced this pull request Feb 28, 2022
@gdavison
Updates CHANGELOG for #151
1114915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gdavison @ewbankkit